From: Roland Hieber <rhi@pengutronix.de>
To: Alexander Dahl <ada@thorsis.com>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/3] os-release: Make date string reproducible
Date: Fri, 28 Feb 2020 16:40:10 +0100 [thread overview]
Message-ID: <20200228154010.t3qdmkrtcojxyf6w@pengutronix.de> (raw)
In-Reply-To: <20200228101609.hq5ubu5zqi6xfklx@pengutronix.de>
On Fri, Feb 28, 2020 at 11:16:09AM +0100, Roland Hieber wrote:
> On Thu, Feb 27, 2020 at 03:44:48PM +0100, Alexander Dahl wrote:
> > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> > ---
> > rules/os-release.make | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/rules/os-release.make b/rules/os-release.make
> > index 5156156a0..ba607aa38 100644
> > --- a/rules/os-release.make
> > +++ b/rules/os-release.make
> > @@ -56,7 +56,7 @@ $(STATEDIR)/os-release.targetinstall: $(PTXDIST_PTXCONFIG) $(PTXDIST_PLATFORMCON
> > @PTXDIST_VERSION@, $(PTXDIST_VERSION_FULL))
> >
> > @$(call install_replace, os-release, /usr/lib/os-release, \
> > - @DATE@, $(shell date +%FT%T%z))
> > + @DATE@, $(shell date --utc --date @$(SOURCE_DATE_EPOCH) '+%FT%T%z'))
>
> So I think we
> should rather set the build date to the modification time of the newest
> source file in the BSP. We could do that by defining a variable in
> scripts/lib/ the same manner as PTXDIST_BSP_AUTOVERSION.
That isn't as easy as I thought, as file mtimes get updated when doing a
VCS checkout. Also we would have to list all files in the BSP (and all
base layers), which could potentially be a very I/O heavy operation, or
need to deal with blacklists or whitelists of folders, but then needed
to make sure nothing in that folders is included in a bash script /
kconfig file / Makefile.
Instead we could use the date of ./tarball-version (like
PTXDIST_BSP_AUTOVERSION does too) or the current VCS commit; or if the
BSP is not a VCS repo, or if the worktree has local changes, fall back
to searching for the most recent file in the current BSP.
Does this sound reasonable?
- Roland
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2020-02-28 15:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 14:44 [ptxdist] [PATCH 0/3] Minor build improvements Alexander Dahl
2020-02-27 14:44 ` [ptxdist] [PATCH 1/3] opkg: Regenerate config after input variable changes Alexander Dahl
2020-03-20 11:31 ` Michael Olbrich
2020-03-27 13:24 ` Michael Olbrich
2020-02-27 14:44 ` [ptxdist] [PATCH 2/3] os-release: Make date string reproducible Alexander Dahl
2020-02-28 10:16 ` Roland Hieber
2020-02-28 15:40 ` Roland Hieber [this message]
2020-02-28 16:14 ` Alexander Dahl
2020-02-29 8:48 ` Michael Olbrich
2020-02-29 17:41 ` Alexander Dahl
2020-03-20 11:38 ` Michael Olbrich
2020-02-27 14:44 ` [ptxdist] [PATCH 3/3] rootfs: issue: " Alexander Dahl
2020-03-20 11:39 ` Michael Olbrich
2020-03-20 12:08 ` Alexander Dahl
2020-03-20 12:44 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228154010.t3qdmkrtcojxyf6w@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=ada@thorsis.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox