[ptxdist] [PATCH] kernel-headers: build out-of-tree

[ptxdist] [PATCH] kernel-headers: build out-of-tree

[Sandy Patterson]

[-- Attachment #1.1: Type: text/plain, Size: 1546 bytes --]

I am not sure if the following patch is what was intended with the change
to OOT=KEEP change for kernel. We have a folder within our BSP with a
kernel tree and we symlink to that folder using local_src/kernel.
<platformname> and local_src/kernel-header.<platformname>.

We use an external kernel source tree and kernel headers from the same
folder. It seems with our kernel at least building the kernel-headers in
tree causes the out-of-tree kernel to fail to build.
---
 rules/kernel-header.make | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/rules/kernel-header.make b/rules/kernel-header.make
index c173eb74b..6f540409f 100644
--- a/rules/kernel-header.make
+++ b/rules/kernel-header.make
@@ -25,8 +25,10 @@ KERNEL_HEADER_URL :=
https://git.kernel.org/torvalds/t/$(KERNEL_HEADER).$(KERNE
 endif
 KERNEL_HEADER_SOURCE :=
$(SRCDIR)/linux-$(KERNEL_HEADER_VERSION).$(KERNEL_HEADER_SUFFIX)
 KERNEL_HEADER_DIR := $(BUILDDIR)/kernel-header-$(KERNEL_HEADER_VERSION)
+KERNEL_HEADER_BUILD_DIR := $(KERNEL_HEADER_DIR)-build
 KERNEL_HEADER_PKGDIR := $(PKGDIR)/kernel-header-$(KERNEL_HEADER_VERSION)
 KERNEL_HEADER_LICENSE := GPL-2.0-only
+KERNEL_HEADER_BUILD_OOT := KEEP

 #
----------------------------------------------------------------------------
 # Prepare
@@ -37,6 +39,7 @@ KERNEL_HEADER_PATH := PATH=$(CROSS_PATH)
 KERNEL_HEADER_CONF_TOOL := NO
 KERNEL_HEADER_MAKE_OPT := \
  V=$(PTXDIST_VERBOSE) \
+ O=$(KERNEL_HEADER_BUILD_DIR) \
  HOSTCC=$(HOSTCC) \
  ARCH=$(GENERIC_KERNEL_ARCH) \
  CROSS_COMPILE=$(PTXCONF_COMPILER_PREFIX)
-- 
2.20.1

[-- Attachment #1.2: Type: text/html, Size: 2565 bytes --]

[-- Attachment #2: Type: text/plain, Size: 92 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] kernel-headers: build out-of-tree

[Michael Olbrich]

On Tue, Feb 25, 2020 at 10:20:34AM -0500, Sandy Patterson wrote:
> I am not sure if the following patch is what was intended with the change
> to OOT=KEEP change for kernel. We have a folder within our BSP with a
> kernel tree and we symlink to that folder using local_src/kernel.
> <platformname> and local_src/kernel-header.<platformname>.
> 
> We use an external kernel source tree and kernel headers from the same
> folder. It seems with our kernel at least building the kernel-headers in
> tree causes the out-of-tree kernel to fail to build.

It's a valid use-case. Can you make the commit message a bit more generic
(no 'we' or 'I' but a general description of the use-case).

Also, the signed-of-by is missing.

And something (probably your mail program) broke the patch. There are a lot
of descriptions online, on how to send patches with various mail programs.
If that doesn't work then a patch as attachment is ok as well.

Michael

> ---
>  rules/kernel-header.make | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/rules/kernel-header.make b/rules/kernel-header.make
> index c173eb74b..6f540409f 100644
> --- a/rules/kernel-header.make
> +++ b/rules/kernel-header.make
> @@ -25,8 +25,10 @@ KERNEL_HEADER_URL :=
> https://git.kernel.org/torvalds/t/$(KERNEL_HEADER).$(KERNE
>  endif
>  KERNEL_HEADER_SOURCE :=
> $(SRCDIR)/linux-$(KERNEL_HEADER_VERSION).$(KERNEL_HEADER_SUFFIX)
>  KERNEL_HEADER_DIR := $(BUILDDIR)/kernel-header-$(KERNEL_HEADER_VERSION)
> +KERNEL_HEADER_BUILD_DIR := $(KERNEL_HEADER_DIR)-build
>  KERNEL_HEADER_PKGDIR := $(PKGDIR)/kernel-header-$(KERNEL_HEADER_VERSION)
>  KERNEL_HEADER_LICENSE := GPL-2.0-only
> +KERNEL_HEADER_BUILD_OOT := KEEP
> 
>  #
> ----------------------------------------------------------------------------
>  # Prepare
> @@ -37,6 +39,7 @@ KERNEL_HEADER_PATH := PATH=$(CROSS_PATH)
>  KERNEL_HEADER_CONF_TOOL := NO
>  KERNEL_HEADER_MAKE_OPT := \
>   V=$(PTXDIST_VERBOSE) \
> + O=$(KERNEL_HEADER_BUILD_DIR) \
>   HOSTCC=$(HOSTCC) \
>   ARCH=$(GENERIC_KERNEL_ARCH) \
>   CROSS_COMPILE=$(PTXCONF_COMPILER_PREFIX)
> -- 
> 2.20.1

> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] kernel-headers: build out-of-tree

[Roland Hieber]

On Wed, Feb 26, 2020 at 06:45:55PM +0100, Michael Olbrich wrote:
> On Tue, Feb 25, 2020 at 10:20:34AM -0500, Sandy Patterson wrote:
> > I am not sure if the following patch is what was intended with the change
> > to OOT=KEEP change for kernel. We have a folder within our BSP with a
> > kernel tree and we symlink to that folder using local_src/kernel.
> > <platformname> and local_src/kernel-header.<platformname>.
> > 
> > We use an external kernel source tree and kernel headers from the same
> > folder. It seems with our kernel at least building the kernel-headers in
> > tree causes the out-of-tree kernel to fail to build.
> 
> It's a valid use-case. Can you make the commit message a bit more generic
> (no 'we' or 'I' but a general description of the use-case).
> 
> Also, the signed-of-by is missing.
> 
> And something (probably your mail program) broke the patch. There are a lot
> of descriptions online, on how to send patches with various mail programs.
> If that doesn't work then a patch as attachment is ok as well.

Of which I learned recently: https://git-send-email.io/

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] kernel-headers: build out-of-tree

[Sandy Patterson]

[-- Attachment #1.1: Type: text/plain, Size: 2844 bytes --]

Sure thing, V2 coming, thanks for the pointers.

On Wed, Feb 26, 2020 at 12:46 PM Michael Olbrich <m.olbrich@pengutronix.de>
wrote:

> On Tue, Feb 25, 2020 at 10:20:34AM -0500, Sandy Patterson wrote:
> > I am not sure if the following patch is what was intended with the change
> > to OOT=KEEP change for kernel. We have a folder within our BSP with a
> > kernel tree and we symlink to that folder using local_src/kernel.
> > <platformname> and local_src/kernel-header.<platformname>.
> >
> > We use an external kernel source tree and kernel headers from the same
> > folder. It seems with our kernel at least building the kernel-headers in
> > tree causes the out-of-tree kernel to fail to build.
>
> It's a valid use-case. Can you make the commit message a bit more generic
> (no 'we' or 'I' but a general description of the use-case).
>
> Also, the signed-of-by is missing.
>
> And something (probably your mail program) broke the patch. There are a lot
> of descriptions online, on how to send patches with various mail programs.
> If that doesn't work then a patch as attachment is ok as well.
>
> Michael
>
> > ---
> >  rules/kernel-header.make | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/rules/kernel-header.make b/rules/kernel-header.make
> > index c173eb74b..6f540409f 100644
> > --- a/rules/kernel-header.make
> > +++ b/rules/kernel-header.make
> > @@ -25,8 +25,10 @@ KERNEL_HEADER_URL :=
> > https://git.kernel.org/torvalds/t/$(KERNEL_HEADER).$(KERNE
> >  endif
> >  KERNEL_HEADER_SOURCE :=
> > $(SRCDIR)/linux-$(KERNEL_HEADER_VERSION).$(KERNEL_HEADER_SUFFIX)
> >  KERNEL_HEADER_DIR := $(BUILDDIR)/kernel-header-$(KERNEL_HEADER_VERSION)
> > +KERNEL_HEADER_BUILD_DIR := $(KERNEL_HEADER_DIR)-build
> >  KERNEL_HEADER_PKGDIR := $(PKGDIR)/kernel-header-$(KERNEL_HEADER_VERSION)
> >  KERNEL_HEADER_LICENSE := GPL-2.0-only
> > +KERNEL_HEADER_BUILD_OOT := KEEP
> >
> >  #
> >
> ----------------------------------------------------------------------------
> >  # Prepare
> > @@ -37,6 +39,7 @@ KERNEL_HEADER_PATH := PATH=$(CROSS_PATH)
> >  KERNEL_HEADER_CONF_TOOL := NO
> >  KERNEL_HEADER_MAKE_OPT := \
> >   V=$(PTXDIST_VERBOSE) \
> > + O=$(KERNEL_HEADER_BUILD_DIR) \
> >   HOSTCC=$(HOSTCC) \
> >   ARCH=$(GENERIC_KERNEL_ARCH) \
> >   CROSS_COMPILE=$(PTXCONF_COMPILER_PREFIX)
> > --
> > 2.20.1
>
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
>
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
>

[-- Attachment #1.2: Type: text/html, Size: 3887 bytes --]

[-- Attachment #2: Type: text/plain, Size: 92 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de