From: Roland Hieber <rhi@pengutronix.de>
To: Sandy Patterson <apatterson@sightlogix.com>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] kernel-headers: build out-of-tree
Date: Thu, 27 Feb 2020 10:28:28 +0100 [thread overview]
Message-ID: <20200227092828.7ofvrcxhbhiih6vf@pengutronix.de> (raw)
In-Reply-To: <20200226174555.GA23059@pengutronix.de>
On Wed, Feb 26, 2020 at 06:45:55PM +0100, Michael Olbrich wrote:
> On Tue, Feb 25, 2020 at 10:20:34AM -0500, Sandy Patterson wrote:
> > I am not sure if the following patch is what was intended with the change
> > to OOT=KEEP change for kernel. We have a folder within our BSP with a
> > kernel tree and we symlink to that folder using local_src/kernel.
> > <platformname> and local_src/kernel-header.<platformname>.
> >
> > We use an external kernel source tree and kernel headers from the same
> > folder. It seems with our kernel at least building the kernel-headers in
> > tree causes the out-of-tree kernel to fail to build.
>
> It's a valid use-case. Can you make the commit message a bit more generic
> (no 'we' or 'I' but a general description of the use-case).
>
> Also, the signed-of-by is missing.
>
> And something (probably your mail program) broke the patch. There are a lot
> of descriptions online, on how to send patches with various mail programs.
> If that doesn't work then a patch as attachment is ok as well.
Of which I learned recently: https://git-send-email.io/
- Roland
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2020-02-27 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 15:20 Sandy Patterson
2020-02-26 17:45 ` Michael Olbrich
2020-02-27 9:28 ` Roland Hieber [this message]
2020-03-02 15:52 ` Sandy Patterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227092828.7ofvrcxhbhiih6vf@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=apatterson@sightlogix.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox