From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j70kt-0005rr-NE for ptxdist@pengutronix.de; Wed, 26 Feb 2020 18:45:55 +0100 Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1j70kt-0001nz-F0 for ptxdist@pengutronix.de; Wed, 26 Feb 2020 18:45:55 +0100 Date: Wed, 26 Feb 2020 18:45:55 +0100 From: Michael Olbrich Message-ID: <20200226174555.GA23059@pengutronix.de> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [ptxdist] [PATCH] kernel-headers: build out-of-tree List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Tue, Feb 25, 2020 at 10:20:34AM -0500, Sandy Patterson wrote: > I am not sure if the following patch is what was intended with the change > to OOT=KEEP change for kernel. We have a folder within our BSP with a > kernel tree and we symlink to that folder using local_src/kernel. > and local_src/kernel-header.. > > We use an external kernel source tree and kernel headers from the same > folder. It seems with our kernel at least building the kernel-headers in > tree causes the out-of-tree kernel to fail to build. It's a valid use-case. Can you make the commit message a bit more generic (no 'we' or 'I' but a general description of the use-case). Also, the signed-of-by is missing. And something (probably your mail program) broke the patch. There are a lot of descriptions online, on how to send patches with various mail programs. If that doesn't work then a patch as attachment is ok as well. Michael > --- > rules/kernel-header.make | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/rules/kernel-header.make b/rules/kernel-header.make > index c173eb74b..6f540409f 100644 > --- a/rules/kernel-header.make > +++ b/rules/kernel-header.make > @@ -25,8 +25,10 @@ KERNEL_HEADER_URL := > https://git.kernel.org/torvalds/t/$(KERNEL_HEADER).$(KERNE > endif > KERNEL_HEADER_SOURCE := > $(SRCDIR)/linux-$(KERNEL_HEADER_VERSION).$(KERNEL_HEADER_SUFFIX) > KERNEL_HEADER_DIR := $(BUILDDIR)/kernel-header-$(KERNEL_HEADER_VERSION) > +KERNEL_HEADER_BUILD_DIR := $(KERNEL_HEADER_DIR)-build > KERNEL_HEADER_PKGDIR := $(PKGDIR)/kernel-header-$(KERNEL_HEADER_VERSION) > KERNEL_HEADER_LICENSE := GPL-2.0-only > +KERNEL_HEADER_BUILD_OOT := KEEP > > # > ---------------------------------------------------------------------------- > # Prepare > @@ -37,6 +39,7 @@ KERNEL_HEADER_PATH := PATH=$(CROSS_PATH) > KERNEL_HEADER_CONF_TOOL := NO > KERNEL_HEADER_MAKE_OPT := \ > V=$(PTXDIST_VERBOSE) \ > + O=$(KERNEL_HEADER_BUILD_DIR) \ > HOSTCC=$(HOSTCC) \ > ARCH=$(GENERIC_KERNEL_ARCH) \ > CROSS_COMPILE=$(PTXCONF_COMPILER_PREFIX) > -- > 2.20.1 > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de