[ptxdist] [PATCH] alsa-lib: add missing use-case-manager -> mixer dependency

[ptxdist] [PATCH] alsa-lib: add missing use-case-manager -> mixer dependency

[Philipp Zabel]

Fixes the following build failure if ALSA_LIB_UCM is enabled but
ALSA_LIB_MIXER is disabled:

    CCLD     libasound.la
  .../arm-v7a-linux-gnueabihf/bin/ld: ucm/.libs/libucm.a(main.o): in function `snd_use_case_parse_selem_id':
  .../alsa-lib-1.2.1.2/src/ucm/main.c:1968: undefined reference to `snd_mixer_selem_id_parse'

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 rules/alsa-lib.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/alsa-lib.in b/rules/alsa-lib.in
index ae859fee376a..23c6c9b1cd1c 100644
--- a/rules/alsa-lib.in
+++ b/rules/alsa-lib.in
@@ -8,6 +8,7 @@ menuconfig ALSA_LIB
 	select LIBC_PTHREAD
 	select LIBC_RT
 	select GCCLIBS_GCC_S
+	select ALSA_LIB_MIXER		if ALSA_LIB_UCM
 	help
 	  This is the userspace library to the kernel's "Advanced Linux Sound Architecture" feature
 
-- 
2.20.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] alsa-lib: add missing use-case-manager -> mixer dependency

[Juergen Borleis]

Hi Phillip,

Am Dienstag, den 25.02.2020, 18:03 +0100 schrieb Philipp Zabel:
> Fixes the following build failure if ALSA_LIB_UCM is enabled but
> ALSA_LIB_MIXER is disabled:
> 
>     CCLD     libasound.la
>   .../arm-v7a-linux-gnueabihf/bin/ld: ucm/.libs/libucm.a(main.o): in function
> `snd_use_case_parse_selem_id':
>   .../alsa-lib-1.2.1.2/src/ucm/main.c:1968: undefined reference to
> `snd_mixer_selem_id_parse'
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  rules/alsa-lib.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/alsa-lib.in b/rules/alsa-lib.in
> index ae859fee376a..23c6c9b1cd1c 100644
> --- a/rules/alsa-lib.in
> +++ b/rules/alsa-lib.in
> @@ -8,6 +8,7 @@ menuconfig ALSA_LIB
>  	select LIBC_PTHREAD
>  	select LIBC_RT
>  	select GCCLIBS_GCC_S
> +	select ALSA_LIB_MIXER		if ALSA_LIB_UCM
>  	help
>  	  This is the userspace library to the kernel's "Advanced Linux Sound Architecture" feature

And I thought I had test *all* permutations...

Acked-by: Juergen Borleis <jbe@pengutronix.de>

-- 
Pengutronix e.K.                       | Juergen Borleis             |
Steuerwalder Str. 21                   | https://www.pengutronix.de/ |
31137 Hildesheim, Germany              | Phone: +49-5121-206917-5128 |
Amtsgericht Hildesheim, HRA 2686       | Fax:   +49-5121-206917-5555 |


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de