From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j6Btb-0004zi-8x for ptxdist@pengutronix.de; Mon, 24 Feb 2020 12:27:31 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1j6Btb-0002Gb-00 for ptxdist@pengutronix.de; Mon, 24 Feb 2020 12:27:31 +0100 Date: Mon, 24 Feb 2020 12:27:30 +0100 From: Michael Olbrich Message-ID: <20200224112730.GE3627@pengutronix.de> References: <20200218145720.4992-1-u.kleine-koenig@pengutronix.de> <20200224110051.fxqc7sjshqwj3mhn@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200224110051.fxqc7sjshqwj3mhn@pengutronix.de> Subject: Re: [ptxdist] [PATCH] unfs3: fix attribute setting for symlinks List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Mon, Feb 24, 2020 at 12:00:51PM +0100, Uwe Kleine-K=F6nig wrote: > On Tue, Feb 18, 2020 at 03:57:20PM +0100, Uwe Kleine-K=F6nig wrote: > > unfs makes use of utime() which is unsuitable to set last access and > > modification times for symlinks. So make use of the O_PATH flag to > > open() and use the futimens() function. > > = > > As a side effect this is less racy and improves resolution from seconds > > to nanoseconds. > > = > > Note this will break builds of unfs on Windows. The futimens() function > > is specified in POSIX.1-2008, so this shouldn't be a problem for other > > platforms. > > = > > Signed-off-by: Uwe Kleine-K=F6nig > = > Here is something fishy. After deploying this patch in a local BSP I see > some errors that were not there before. > = > So please hold up merging until I found the time to look into these > issues please. It's already in master. Michael -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de