From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] unfs3: fix attribute setting for symlinks
Date: Mon, 24 Feb 2020 12:27:30 +0100 [thread overview]
Message-ID: <20200224112730.GE3627@pengutronix.de> (raw)
In-Reply-To: <20200224110051.fxqc7sjshqwj3mhn@pengutronix.de>
On Mon, Feb 24, 2020 at 12:00:51PM +0100, Uwe Kleine-König wrote:
> On Tue, Feb 18, 2020 at 03:57:20PM +0100, Uwe Kleine-König wrote:
> > unfs makes use of utime() which is unsuitable to set last access and
> > modification times for symlinks. So make use of the O_PATH flag to
> > open() and use the futimens() function.
> >
> > As a side effect this is less racy and improves resolution from seconds
> > to nanoseconds.
> >
> > Note this will break builds of unfs on Windows. The futimens() function
> > is specified in POSIX.1-2008, so this shouldn't be a problem for other
> > platforms.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Here is something fishy. After deploying this patch in a local BSP I see
> some errors that were not there before.
>
> So please hold up merging until I found the time to look into these
> issues please.
It's already in master.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2020-02-24 11:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 14:57 Uwe Kleine-König
2020-02-24 11:00 ` Uwe Kleine-König
2020-02-24 11:27 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224112730.GE3627@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox