From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <ukl@pengutronix.de>) id 1j6BTo-0001kP-2T
 for ptxdist@pengutronix.de; Mon, 24 Feb 2020 12:00:52 +0100
Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89)
 (envelope-from <ukl@pengutronix.de>) id 1j6BTn-0002MO-PJ
 for ptxdist@pengutronix.de; Mon, 24 Feb 2020 12:00:51 +0100
Date: Mon, 24 Feb 2020 12:00:51 +0100
From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
Message-ID: <20200224110051.fxqc7sjshqwj3mhn@pengutronix.de>
References: <20200218145720.4992-1-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20200218145720.4992-1-u.kleine-koenig@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] unfs3: fix attribute setting for symlinks
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de

On Tue, Feb 18, 2020 at 03:57:20PM +0100, Uwe Kleine-K=F6nig wrote:
> unfs makes use of utime() which is unsuitable to set last access and
> modification times for symlinks. So make use of the O_PATH flag to
> open() and use the futimens() function.
> =

> As a side effect this is less racy and improves resolution from seconds
> to nanoseconds.
> =

> Note this will break builds of unfs on Windows. The futimens() function
> is specified in POSIX.1-2008, so this shouldn't be a problem for other
> platforms.
> =

> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Here is something fishy. After deploying this patch in a local BSP I see
some errors that were not there before.

So please hold up merging until I found the time to look into these
issues please.

Best regards
Uwe

-- =

Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de