From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j538w-00012W-5U for ptxdist@pengutronix.de; Fri, 21 Feb 2020 08:54:38 +0100 Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1j538v-00047R-RT for ptxdist@pengutronix.de; Fri, 21 Feb 2020 08:54:37 +0100 Date: Fri, 21 Feb 2020 08:54:37 +0100 From: Michael Olbrich Message-ID: <20200221075437.GA3903@pengutronix.de> References: <20200220111756.16577-1-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [ptxdist] [PATCH v2] zstd: new package List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Fri, Feb 21, 2020 at 08:12:37AM +0100, Bruno Thomsen wrote: > Hi > > Den tor. 20. feb. 2020 kl. 12.20 skrev Philipp Zabel : > > +# ---------------------------------------------------------------------------- > > +# Target-Install > > +# ---------------------------------------------------------------------------- > > + > > +$(STATEDIR)/zstd.targetinstall: > > + @$(call targetinfo) > > This section did not work in my test as indentation is space and not tab. > > /home/developer/git/ptxdist/rules/zstd.make:55: *** missing separator. Stop. I got the tabs here, so maybe something went wrong on your side. > > + > > + @$(call install_init, zstd) > > + @$(call install_fixup, zstd, PRIORITY, optional) > > + @$(call install_fixup, zstd, SECTION, base) > > + @$(call install_fixup, zstd, AUTHOR, "Florian Faber ") > > + @$(call install_fixup, zstd, DESCRIPTION, missing) > > + > > +ifdef PTXCONF_ZSTD_LIBZSTD > > + $(call install_lib, zstd, 0, 0, 0644, libzstd) > > Target-Install lines normally starts with @, e.g. > @$(call install_lib, zstd, 0, 0, 0644, libzstd) > > Same for the next 6 lines. Indeed. > Bruno > > > +endif > > +ifdef PTXCONF_ZSTD_ZSTD > > + $(call install_copy, zstd, 0, 0, 0755, -, /usr/bin/zstd) > > + $(call install_link, zstd, zstd, /usr/bin/zstdcat) > > + $(call install_link, zstd, zstd, /usr/bin/zstdmt) > > + $(call install_link, zstd, zstd, /usr/bin/unzstd) > > +endif > > +ifdef PTXCONF_ZSTD_ZSTDGREP > > + $(call install_copy, zstd, 0, 0, 0755, -, /usr/bin/zstdgrep) > > +endif > > +ifdef PTXCONF_ZSTD_ZSTDLESS > > + $(call install_copy, zstd, 0, 0, 0755, -, /usr/bin/zstdless) > > +endif > > + > > + @$(call install_finish, zstd) > > + > > + @$(call touch) # vim: syntax=make missing at the end. Michael > > -- > > 2.20.1 > > > > > > _______________________________________________ > > ptxdist mailing list > > ptxdist@pengutronix.de > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de