Re: [ptxdist] [PATCH] sqlite: enable foreign keys by default

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sat, Feb 15, 2020 at 01:52:05PM +0100, Bruno Thomsen wrote:
> Support for foreign_keys pragma was already enabled at
> compile-time, but it was not enabled by default on new
> database connections. It's still possible to turn off
> enforcement at runtime.
> This makes it easier to work on databases that uses
> this feature without causing them to end up in an
> invalid state.

Hmm, what's the impact of this? What are the performance implications? And
what's the default in other distros? I mean, if the default is generally
off, then I don't expect any existing software to disable this.

Michael

> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
>  rules/sqlite.make | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/sqlite.make b/rules/sqlite.make
> index b23c2d377..e0b26e3cb 100644
> --- a/rules/sqlite.make
> +++ b/rules/sqlite.make
> @@ -42,6 +42,7 @@ SQLITE_CONF_ENV := \
>  	$(CROSS_ENV) \
>  	ac_cv_header_zlib_h=no \
>  	CPPFLAGS=" \
> +	-DSQLITE_DEFAULT_FOREIGN_KEYS=1 \
>  	-DSQLITE_ENABLE_COLUMN_METADATA=1 \
>  	-DSQLITE_ENABLE_FTS3_PARENTHESIS=1 \
>  	-DSQLITE_ENABLE_UNLOCK_NOTIFY=1 \
> -- 
> 2.24.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de