From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j3dhs-0006ds-Mq for ptxdist@pengutronix.de; Mon, 17 Feb 2020 11:32:52 +0100 Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1j3dhs-0007qa-Ev for ptxdist@pengutronix.de; Mon, 17 Feb 2020 11:32:52 +0100 Date: Mon, 17 Feb 2020 11:32:52 +0100 From: Michael Olbrich Message-ID: <20200217103252.GC11721@pengutronix.de> References: <20200205104241.19603-1-u.oelmann@pengutronix.de> <20200205104241.19603-3-u.oelmann@pengutronix.de> <20200214125023.GG7958@pengutronix.de> <20200217095012.uqmp2aspk7s7nhzm@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200217095012.uqmp2aspk7s7nhzm@pengutronix.de> Subject: Re: [ptxdist] [PATCH v5 3/3] open62541: new package List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Mon, Feb 17, 2020 at 10:50:12AM +0100, Roland Hieber wrote: > On Fri, Feb 14, 2020 at 01:50:23PM +0100, Michael Olbrich wrote: > > On Wed, Feb 05, 2020 at 11:42:41AM +0100, Ulrich =D6lmann wrote: > = > [...] > = > > > diff --git a/rules/open62541.make b/rules/open62541.make > > > new file mode 100644 > > > index 000000000000..62e030ed3752 > > > --- /dev/null > > > +++ b/rules/open62541.make > > > @@ -0,0 +1,140 @@ > > > +# -*-makefile-*- > > > +# > > > +# Copyright (C) 2018 by Robert Schwebel > > > +# Copyright (C) 2019 by Bjoern Esser > > > +# > > > +# See CREDITS for details about who has contributed to this project. > > > +# > > > +# For further information about the PTXdist project and license cond= itions > > > +# see the README file. > > > +# > > > + > > > +# > > > +# We provide this package > > > +# > > > +PACKAGES-$(PTXCONF_OPEN62541) +=3D open62541 > > > + > > > +# > > > +# Paths and names > > > +# > > > +OPEN62541_VERSION :=3D 1.0 > > > +OPEN62541_MD5 :=3D b8e02d7310e8b48faf52efc539fa9496 > > > +OPEN62541 :=3D open62541-$(OPEN62541_VERSION) > > > +OPEN62541_SUFFIX :=3D tar.gz > > > +OPEN62541_URL :=3D https://github.com/open62541/open62541/archive/= v$(OPEN62541_VERSION)/$(OPEN62541).$(OPEN62541_SUFFIX) > > > +OPEN62541_SOURCE :=3D $(SRCDIR)/$(OPEN62541).$(OPEN62541_SUFFIX) > > > +OPEN62541_DIR :=3D $(BUILDDIR)/$(OPEN62541) > > > +OPEN62541_LICENSE :=3D MPL-2.0 > > > +OPEN62541_LICENSE_FILES :=3D file://LICENSE;md5=3D815ca599c9df247a0= c7f619bab123dad > > > + > > > +OPEN62541_MDNSD_VERSION :=3D 4bd993e0fdd06d54c8fd0b8f416cda6a8db185= 85 > > > +OPEN62541_MDNSD_MD5 :=3D 0961fc8dc253753ec8ea157104671498 > > > +OPEN62541_MDNSD_URL :=3D https://github.com/Pro/mdnsd/archive/$(OPE= N62541_MDNSD_VERSION)/open62541-mdnsd-$(OPEN62541_MDNSD_VERSION).tar.gz > > > +OPEN62541_MDNSD_SOURCE :=3D $(SRCDIR)/open62541-mdnsd-$(OPEN62541_M= DNSD_VERSION).tar.gz > > = > > The suffix deserves a separate variable. > = > I'm curious why, is it used by anything other than the URL? Well, having a _VERSION makes the diff for updates easier to read. _SOURCE and _URL and _MD5 are always needed. And now that I look closer, OPEN62541_MDNSD should be set as well. This and _SUFFIX make it clearer that _SOURCE and URL are in sync. Michael -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de