From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2tQL-0003eD-2n for ptxdist@pengutronix.de; Sat, 15 Feb 2020 10:07:41 +0100 Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1j2tQK-00033G-Pc for ptxdist@pengutronix.de; Sat, 15 Feb 2020 10:07:40 +0100 Date: Sat, 15 Feb 2020 10:07:40 +0100 From: Michael Olbrich Message-ID: <20200215090740.GA21732@pengutronix.de> References: <20200214110744.17260-1-guille.rodriguez@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [ptxdist] [PATCH] u-boot: Add support for custom make options List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Fri, Feb 14, 2020 at 12:13:31PM +0100, Guillermo Rodriguez Garcia wrote: > Hi all, > = > A little explanation on this. > = > I need to pass DEVICE_TREE=3Dxxx to uboot as this is the "official" way > to build u-boot for the stm32mp1 platform with a device tree other > than the board's default. I started preparing a patch to allow setting > a DEVICE_TREE value specifically, but there are other ways to do the > same, e.g. EXT_DTB to specify a precompiled device tree instead. So I > though perhaps a generic mechanism would be more useful. I also had a > look at buildroot and a similar (generic) mechanism exists as well, so > I ended up doing it like that. Can you put that explanation in the commit message please? It'll ensure that I won't remove the option in the future because I think its not needed. Michael > Comments welcome. > = > Guillermo > = > El vie., 14 feb. 2020 a las 12:07, Guillermo Rodr=EDguez > () escribi=F3: > > > > Add a generic mechanism to allow passing custom make options to > > U-boot. This can be used for example to pass a DEVICE_TREE=3D value. > > > > Signed-off-by: Guillermo Rodriguez > > --- > > platforms/u-boot.in | 7 +++++++ > > rules/u-boot.make | 3 ++- > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/platforms/u-boot.in b/platforms/u-boot.in > > index 50fb008a3..491faed60 100644 > > --- a/platforms/u-boot.in > > +++ b/platforms/u-boot.in > > @@ -71,6 +71,13 @@ config U_BOOT_CONFIG > > > > endif > > > > +config U_BOOT_CUSTOM_MAKE_OPTS > > + prompt "Custom make options" > > + string > > + help > > + List of custom make options passed at build time. Can be > > + used for example to pass a DEVICE_TREE=3D value. > > + > > choice > > prompt "Generate environment image" > > default U_BOOT_ENV_IMAGE_NONE > > diff --git a/rules/u-boot.make b/rules/u-boot.make > > index 0c6bccc71..e386dc4d2 100644 > > --- a/rules/u-boot.make > > +++ b/rules/u-boot.make > > @@ -55,7 +55,8 @@ U_BOOT_WRAPPER_BLACKLIST :=3D \ > > U_BOOT_CONF_OPT :=3D \ > > -C $(U_BOOT_DIR) \ > > O=3D$(U_BOOT_BUILD_DIR) \ > > - V=3D$(PTXDIST_VERBOSE) > > + V=3D$(PTXDIST_VERBOSE) \ > > + $(call remove_quotes,$(PTXCONF_U_BOOT_CUSTOM_MAKE_OPTS)) > > > > U_BOOT_MAKE_ENV :=3D \ > > CROSS_COMPILE=3D$(BOOTLOADER_CROSS_COMPILE) \ > > -- > > 2.21.0 > > > = > = > -- = > Guillermo Rodriguez Garcia > guille.rodriguez@gmail.com > = > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de