Re: [ptxdist] [PATCH] gettext: deterministically build with included libraries

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Feb 13, 2020 at 06:22:05PM +0100, Matthias Schiffer wrote:
> gettext's configure will automatically used the libraries it finds, and
> fall back to included versions otherwise. Avoid this non-deterministic
> behaviour by explicitly choosing the included libraries.
> 
> In particular, this issue can break parallel builds with --force after
> config changes due to a race condition:
> 
> 1. gettext configure finds libraries from a previous build in sysroot,
>    decides not to use the included libraries
> 2. Installed libraries gets cleaned from sysroot due to --force
> 3. gettext build fails, as it attemps to use the now removed libraries

I'd prefer to select glib and libxml instead. Or are there any reasons not
to do this?

The only current user is parted. Do you know why it needs that on the
target anyways? Most packages only need gettext at runtime.

Michael

> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
>  rules/gettext.make | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/rules/gettext.make b/rules/gettext.make
> index dd1d22ffb..199616c87 100644
> --- a/rules/gettext.make
> +++ b/rules/gettext.make
> @@ -54,10 +54,16 @@ GETTEXT_AUTOCONF := \
>  	--disable-acl \
>  	--disable-openmp \
>  	--disable-curses \
> +	--with-included-gettext \
> +	--with-included-glib \
> +	--with-included-libcroco \
> +	--with-included-libunistring \
> +	--with-included-libxml \
>  	--without-emacs \
>  	--without-bzip2 \
>  	--without-xz
>  
> +
>  # ----------------------------------------------------------------------------
>  # Target-Install
>  # ----------------------------------------------------------------------------
> -- 
> 2.17.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de