From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.tq-group.com ([62.157.118.193]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2ICW-0006ag-0G for ptxdist@pengutronix.de; Thu, 13 Feb 2020 18:22:56 +0100 From: Matthias Schiffer Date: Thu, 13 Feb 2020 18:22:05 +0100 Message-Id: <20200213172208.22452-3-matthias.schiffer@ew.tq-group.com> In-Reply-To: <20200213172208.22452-1-matthias.schiffer@ew.tq-group.com> References: <20200213172208.22452-1-matthias.schiffer@ew.tq-group.com> Subject: [ptxdist] [PATCH] gettext: deterministically build with included libraries List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de Cc: matthias.schiffer@ew.tq-group.com gettext's configure will automatically used the libraries it finds, and fall back to included versions otherwise. Avoid this non-deterministic behaviour by explicitly choosing the included libraries. In particular, this issue can break parallel builds with --force after config changes due to a race condition: 1. gettext configure finds libraries from a previous build in sysroot, decides not to use the included libraries 2. Installed libraries gets cleaned from sysroot due to --force 3. gettext build fails, as it attemps to use the now removed libraries Signed-off-by: Matthias Schiffer --- rules/gettext.make | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/rules/gettext.make b/rules/gettext.make index dd1d22ffb..199616c87 100644 --- a/rules/gettext.make +++ b/rules/gettext.make @@ -54,10 +54,16 @@ GETTEXT_AUTOCONF := \ --disable-acl \ --disable-openmp \ --disable-curses \ + --with-included-gettext \ + --with-included-glib \ + --with-included-libcroco \ + --with-included-libunistring \ + --with-included-libxml \ --without-emacs \ --without-bzip2 \ --without-xz + # ---------------------------------------------------------------------------- # Target-Install # ---------------------------------------------------------------------------- -- 2.17.1 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de