From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixofQ-0007Fo-OK for ptxdist@pengutronix.de; Sat, 01 Feb 2020 10:02:16 +0100 Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1ixofQ-0008SM-Gj for ptxdist@pengutronix.de; Sat, 01 Feb 2020 10:02:16 +0100 Date: Sat, 1 Feb 2020 10:02:16 +0100 From: Michael Olbrich Message-ID: <20200201090216.GG2615@pengutronix.de> References: <20200119213753.GB2030445@lenoch> <20200130221739.GA256488@lenoch> <20200131070907.npl35y4fkylizp4x@pengutronix.de> <20200131213731.GA438064@lenoch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200131213731.GA438064@lenoch> Subject: Re: [ptxdist] [PATCH] gpsd: version bump 3.19 -> 3.20 List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Fri, Jan 31, 2020 at 10:37:31PM +0100, Ladislav Michl wrote: > On Fri, Jan 31, 2020 at 08:09:07AM +0100, Michael Olbrich wrote: > > On Thu, Jan 30, 2020 at 11:17:39PM +0100, Ladislav Michl wrote: > > > On Sun, Jan 19, 2020 at 10:37:53PM +0100, Ladislav Michl wrote: > > > > Quite a few options were removed, so remome them from Kconfig as well. > > > > Buildsystem counts on gcc to be used for linking and setting LD makes > > > > build fail, so set only those tools actually used. > > > > > > Well, just do not hold your breath here... Turned out about half of commits > > > that went into gpsd git after 3.20 deserve to be turned into patches and made > > > part of this update. So let's just stick with 3.19 before 3.20.1 shows up. > > > > I noticed. I've been working on eliminating the python2 and gpsd one of the > > remaining users. The commits since the 3.20 release look like we can switch > > to python3 after the next release. > > Also, with 3.20 the python bindings fail to build. I didn't look closer but > > I think there is some python2/python3 issue. > > Well, at least we should remove extra space from LDFLAGS, that makes this > part of SConstruct fail: > for flag in ['CFLAGS', 'LDFLAGS', 'OPT']: > python_env.MergeFlags(Split(python_config[flag])) > > SConstruct is also using INCLUDEPY: > CPPPATH=[python_config['INCLUDEPY']], > but our INCLUDEPY is lacking SYSROOT_TARGET prefix (/usr/include/python3.7m) > Manually tweaking _sysconfigdata_m_linux2_x86_64-linux-gnu.py > makes it build (well, it still fails later, but these two > needs to be fixed first) > > (I switched gpsd to git version locally to be able to get better > test coverage and added pyserial dependency where needed) Well this patch and the 3.20 update still fails here with: .../bin/ld: gpspacket-py_2_7_16_final_0.cpython-37m-arm-linux-gnueabihf.so: in function `Lexer_dealloc': platform-arm-hf/build-target/gpsd-3.20/gpspacket.c:129: undefined reference to `PyObject_Free' This looks suspicious to me: 2.7.16 is python2 version... I think there is some stuff leaking in from the build Python. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de