mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] gpsd: version bump 3.19 -> 3.20
Date: Sat, 1 Feb 2020 10:02:16 +0100	[thread overview]
Message-ID: <20200201090216.GG2615@pengutronix.de> (raw)
In-Reply-To: <20200131213731.GA438064@lenoch>

On Fri, Jan 31, 2020 at 10:37:31PM +0100, Ladislav Michl wrote:
> On Fri, Jan 31, 2020 at 08:09:07AM +0100, Michael Olbrich wrote:
> > On Thu, Jan 30, 2020 at 11:17:39PM +0100, Ladislav Michl wrote:
> > > On Sun, Jan 19, 2020 at 10:37:53PM +0100, Ladislav Michl wrote:
> > > > Quite a few options were removed, so remome them from Kconfig as well.
> > > > Buildsystem counts on gcc to be used for linking and setting LD makes
> > > > build fail, so set only those tools actually used.
> > > 
> > > Well, just do not hold your breath here... Turned out about half of commits
> > > that went into gpsd git after 3.20 deserve to be turned into patches and made
> > > part of this update. So let's just stick with 3.19 before 3.20.1 shows up.
> > 
> > I noticed. I've been working on eliminating the python2 and gpsd one of the
> > remaining users. The commits since the 3.20 release look like we can switch
> > to python3 after the next release.
> > Also, with 3.20 the python bindings fail to build. I didn't look closer but
> > I think there is some python2/python3 issue.
> 
> Well, at least we should remove extra space from LDFLAGS, that makes this
> part of SConstruct fail:
>     for flag in ['CFLAGS', 'LDFLAGS', 'OPT']:
>         python_env.MergeFlags(Split(python_config[flag]))
> 
> SConstruct is also using INCLUDEPY:
> CPPPATH=[python_config['INCLUDEPY']],
> but our INCLUDEPY is lacking SYSROOT_TARGET prefix (/usr/include/python3.7m)
> Manually tweaking _sysconfigdata_m_linux2_x86_64-linux-gnu.py
> makes it build (well, it still fails later, but these two
> needs to be fixed first)
> 
> (I switched gpsd to git version locally to be able to get better
> test coverage and added pyserial dependency where needed)

Well this patch and the 3.20 update still fails here with:

.../bin/ld: gpspacket-py_2_7_16_final_0.cpython-37m-arm-linux-gnueabihf.so:
in function `Lexer_dealloc':
platform-arm-hf/build-target/gpsd-3.20/gpspacket.c:129: undefined reference
to `PyObject_Free'

This looks suspicious to me: 2.7.16 is python2 version... I think there is
some stuff leaking in from the build Python.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2020-02-01  9:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-19 21:37 Ladislav Michl
2020-01-30 22:17 ` Ladislav Michl
2020-01-31  7:09   ` Michael Olbrich
2020-01-31 21:37     ` Ladislav Michl
2020-02-01  9:02       ` Michael Olbrich [this message]
2020-02-01 19:43         ` Ladislav Michl
2020-02-02 13:18         ` Ladislav Michl
2020-02-04  1:02         ` Ladislav Michl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200201090216.GG2615@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox