Re: [ptxdist] [PATCH] gpsd: version bump 3.19 -> 3.20

[Ladislav Michl <ladis@linux-mips.org>]

On Fri, Jan 31, 2020 at 08:09:07AM +0100, Michael Olbrich wrote:
> On Thu, Jan 30, 2020 at 11:17:39PM +0100, Ladislav Michl wrote:
> > On Sun, Jan 19, 2020 at 10:37:53PM +0100, Ladislav Michl wrote:
> > > Quite a few options were removed, so remome them from Kconfig as well.
> > > Buildsystem counts on gcc to be used for linking and setting LD makes
> > > build fail, so set only those tools actually used.
> > 
> > Well, just do not hold your breath here... Turned out about half of commits
> > that went into gpsd git after 3.20 deserve to be turned into patches and made
> > part of this update. So let's just stick with 3.19 before 3.20.1 shows up.
> 
> I noticed. I've been working on eliminating the python2 and gpsd one of the
> remaining users. The commits since the 3.20 release look like we can switch
> to python3 after the next release.
> Also, with 3.20 the python bindings fail to build. I didn't look closer but
> I think there is some python2/python3 issue.

Well, at least we should remove extra space from LDFLAGS, that makes this
part of SConstruct fail:
    for flag in ['CFLAGS', 'LDFLAGS', 'OPT']:
        python_env.MergeFlags(Split(python_config[flag]))

SConstruct is also using INCLUDEPY:
CPPPATH=[python_config['INCLUDEPY']],
but our INCLUDEPY is lacking SYSROOT_TARGET prefix (/usr/include/python3.7m)
Manually tweaking _sysconfigdata_m_linux2_x86_64-linux-gnu.py
makes it build (well, it still fails later, but these two
needs to be fixed first)

(I switched gpsd to git version locally to be able to get better
test coverage and added pyserial dependency where needed)

--- >8 ---

From: Ladislav Michl <ladis@linux-mips.org>
Date: Fri, 31 Jan 2020 22:16:05 +0100
Subject: [PATCH] python3: remove extra space from LDFLAGS

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 rules/host-python3.make | 2 +-
 rules/python3.make      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/rules/host-python3.make b/rules/host-python3.make
index 02063da07..0b30e215f 100644
--- a/rules/host-python3.make
+++ b/rules/host-python3.make
@@ -29,7 +29,7 @@ HOST_PYTHON3_ENV	:= \
 	ac_sys_system=Linux \
 	ac_sys_release=2 \
 	MACHDEP=linux2 \
-	LDFLAGS="-L $(PTXDIST_SYSROOT_HOST)/lib"
+	LDFLAGS="-L$(PTXDIST_SYSROOT_HOST)/lib"
 
 #
 # autoconf
diff --git a/rules/python3.make b/rules/python3.make
index bbda265c2..8bc5c772d 100644
--- a/rules/python3.make
+++ b/rules/python3.make
@@ -48,7 +48,7 @@ PYTHON3_CONF_ENV	:= \
 	ac_cv_file__dev_ptc=no \
 	ac_cv_working_tzset=yes \
 	ac_cv_header_bluetooth_bluetooth_h=no \
-	LDFLAGS="-L $(PTXDIST_SYSROOT_TARGET)/usr/lib"
+	LDFLAGS="-L$(PTXDIST_SYSROOT_TARGET)/usr/lib"
 
 PYTHON3_BINCONFIG_GLOB := ""
 
-- 
2.25.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de