From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Tue, 28 Jan 2020 11:57:29 +0100 From: Roland Hieber Message-ID: <20200128105729.as55c4aikvzy6hfx@pengutronix.de> References: <20200127085111.GA901743@lenoch> <20200127085230.GB901743@lenoch> <20200127095748.lk4kxca6tlfvmi57@pengutronix.de> <20200127155712.GA904994@lenoch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200127155712.GA904994@lenoch> Subject: Re: [ptxdist] [PATCH v2 1/4] pam: new package List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: Ladislav Michl Cc: ptxdist@pengutronix.de On Mon, Jan 27, 2020 at 04:57:12PM +0100, Ladislav Michl wrote: > On Mon, Jan 27, 2020 at 10:57:48AM +0100, Roland Hieber wrote: > > On Mon, Jan 27, 2020 at 09:52:30AM +0100, Ladislav Michl wrote: > > > Signed-off-by: Ladislav Michl > > > --- > > > Note: Package states, that alternatively GPL can be used as a license. > > > There is no GPL version specification and also some files claims LGPL > > > can be used. Also without specifying version. Debian package references > > > /usr/share/common-licenses/GPL which is symlink to actual GPL version > > > (GPL-3). Based on package age, we could probably read license as > > > GPL-2.0-or-later. > > > > Yeah, I think we can use GPL-2.0-or-later here, given that there are > > some PAM modules that specifically mention this version (e.g. > > modules/pam_loginuid/). Please also include AND LGPL-2.0-or-later > > because of modules/pam_mkhomedir/ and modules/pam_issue/. > > Hmm, do we expect C operator precedence or better write it like this: > PAM_LICENSE := BSD-3-Clause OR (GPL-2.0-or-later AND LGPL-2.0-or-later) > > I wouldn't use extra parentheses... I think SPDX syntax requires parentheses in any case, but I'm not sure. Too many parentheses are not wrong however, and better readable. - Roland -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de