From: Roland Hieber <rhi@pengutronix.de>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2 1/4] pam: new package
Date: Tue, 28 Jan 2020 11:57:29 +0100 [thread overview]
Message-ID: <20200128105729.as55c4aikvzy6hfx@pengutronix.de> (raw)
In-Reply-To: <20200127155712.GA904994@lenoch>
On Mon, Jan 27, 2020 at 04:57:12PM +0100, Ladislav Michl wrote:
> On Mon, Jan 27, 2020 at 10:57:48AM +0100, Roland Hieber wrote:
> > On Mon, Jan 27, 2020 at 09:52:30AM +0100, Ladislav Michl wrote:
> > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> > > ---
> > > Note: Package states, that alternatively GPL can be used as a license.
> > > There is no GPL version specification and also some files claims LGPL
> > > can be used. Also without specifying version. Debian package references
> > > /usr/share/common-licenses/GPL which is symlink to actual GPL version
> > > (GPL-3). Based on package age, we could probably read license as
> > > GPL-2.0-or-later.
> >
> > Yeah, I think we can use GPL-2.0-or-later here, given that there are
> > some PAM modules that specifically mention this version (e.g.
> > modules/pam_loginuid/). Please also include AND LGPL-2.0-or-later
> > because of modules/pam_mkhomedir/ and modules/pam_issue/.
>
> Hmm, do we expect C operator precedence or better write it like this:
> PAM_LICENSE := BSD-3-Clause OR (GPL-2.0-or-later AND LGPL-2.0-or-later)
>
> I wouldn't use extra parentheses...
I think SPDX syntax requires parentheses in any case, but I'm not sure.
Too many parentheses are not wrong however, and better readable.
- Roland
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2020-01-28 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 8:51 [ptxdist] [PATCH v2 0/4] PAM Ladislav Michl
2020-01-27 8:52 ` [ptxdist] [PATCH v2 1/4] pam: new package Ladislav Michl
2020-01-27 9:57 ` Roland Hieber
2020-01-27 15:57 ` Ladislav Michl
2020-01-28 10:57 ` Roland Hieber [this message]
2020-01-28 19:48 ` [ptxdist] [PATCH v3] " Ladislav Michl
2020-01-29 9:44 ` Roland Hieber
2020-01-27 8:53 ` [ptxdist] [PATCH v2 2/4] Introduce global PAM option Ladislav Michl
2020-01-27 8:53 ` [ptxdist] [PATCH v2 3/4] shadow: new package Ladislav Michl
2020-01-27 8:54 ` [ptxdist] [PATCH v2 4/4] util-linux: optionally build login program Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128105729.as55c4aikvzy6hfx@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=ladis@linux-mips.org \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox