Re: [ptxdist] [PATCH v2 1/4] pam: new package

[Roland Hieber <rhi@pengutronix.de>]

On Mon, Jan 27, 2020 at 09:52:30AM +0100, Ladislav Michl wrote:
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
>  Note: Package states, that alternatively GPL can be used as a license.
>  There is no GPL version specification and also some files claims LGPL
>  can be used. Also without specifying version. Debian package references
>  /usr/share/common-licenses/GPL which is symlink to actual GPL version
>  (GPL-3). Based on package age, we could probably read license as
>  GPL-2.0-or-later.

Yeah, I think we can use GPL-2.0-or-later here, given that there are
some PAM modules that specifically mention this version (e.g.
modules/pam_loginuid/).  Please also include AND LGPL-2.0-or-later
because of modules/pam_mkhomedir/ and modules/pam_issue/.

Otherwise looks fine to me. Thanks!

 - Roland

>  
>  Changes:
>  - v2: Add license info, install_alternative config files individually
> 
>  rules/pam.in   | 10 ++++++
>  rules/pam.make | 82 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 92 insertions(+)
>  create mode 100644 rules/pam.in
>  create mode 100644 rules/pam.make
> 
> diff --git a/rules/pam.in b/rules/pam.in
> new file mode 100644
> index 000000000..75d5ef42c
> --- /dev/null
> +++ b/rules/pam.in
> @@ -0,0 +1,10 @@
> +## SECTION=security
> +
> +config PAM
> +	tristate
> +	prompt "PAM"
> +	select LIBC_CRYPT
> +	help
> +	  Linux-PAM (Pluggable Authentication Modules for Linux) is a suite
> +	  of shared libraries that enable the local system administrator to
> +	  choose how applications authenticate users.
> diff --git a/rules/pam.make b/rules/pam.make
> new file mode 100644
> index 000000000..2ae37c40e
> --- /dev/null
> +++ b/rules/pam.make
> @@ -0,0 +1,82 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2020 by Ladislav Michl <ladis@linux-mips.org>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_PAM) += pam
> +
> +#
> +# Paths and names
> +#
> +PAM_VERSION	:= 1.3.1
> +PAM_MD5		:= 558ff53b0fc0563ca97f79e911822165
> +PAM		:= Linux-PAM-$(PAM_VERSION)
> +PAM_SUFFIX	:= tar.xz
> +PAM_URL		:= https://github.com/linux-pam/linux-pam/releases/download/v$(PAM_VERSION)/$(PAM).$(PAM_SUFFIX)
> +PAM_SOURCE	:= $(SRCDIR)/$(PAM).$(PAM_SUFFIX)
> +PAM_DIR		:= $(BUILDDIR)/$(PAM)
> +PAM_LICENSE	:= BSD-3-Clause OR GPL-2.0-or-later
> +PAM_LICENSE_FILES := \
> +	file://Copyright;md5=7eb5c1bf854e8881005d673599ee74d3 \
> +	file://COPYING;md5=7eb5c1bf854e8881005d673599ee74d3
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# autoconf
> +#
> +PAM_CONF_TOOL	:= autoconf
> +PAM_CONF_OPT	:= \
> +	$(CROSS_AUTOCONF_USR) \
> +	$(GLOBAL_LARGE_FILE_OPTION) \
> +	--disable-lckpwdf \
> +	--disable-cracklib \
> +	--disable-audit \
> +	--disable-db \
> +	--disable-nis \
> +	--disable-selinux \
> +	--disable-regenerate-docu \
> +	--disable-nls \
> +	--disable-rpath
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/pam.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, pam)
> +	@$(call install_fixup, pam,PRIORITY,optional)
> +	@$(call install_fixup, pam,SECTION,base)
> +	@$(call install_fixup, pam,AUTHOR,"Ladislav Michl <ladis@linux-mips.org>")
> +	@$(call install_fixup, pam,DESCRIPTION,"Pluggable Authentication Modules for Linux")
> +
> +	@$(call install_lib, pam, 0, 0, 0644, libpamc)
> +	@$(call install_lib, pam, 0, 0, 0644, libpam_misc)
> +	@$(call install_lib, pam, 0, 0, 0644, libpam)
> +
> +	@$(call install_tree, pam, 0, 0, -, /usr/lib/security)
> +
> +	@$(call install_alternative, pam, 0, 0, 0644, /etc/environment)
> +	@$(call install_alternative, pam, 0, 0, 0644, /etc/security/access.conf)
> +	@$(call install_alternative, pam, 0, 0, 0644, /etc/security/group.conf)
> +	@$(call install_alternative, pam, 0, 0, 0644, /etc/security/limits.conf)
> +	@$(call install_alternative, pam, 0, 0, 0644, /etc/security/namespace.conf)
> +	@$(call install_alternative, pam, 0, 0, 0755, /etc/security/namespace.init)
> +	@$(call install_alternative, pam, 0, 0, 0644, /etc/security/pam_env.conf)
> +	@$(call install_alternative, pam, 0, 0, 0644, /etc/security/time.conf)
> +
> +	@$(call install_finish, pam)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 2.25.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de