mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] udev-legacy: Fix build with recent glibc versions.
Date: Fri, 24 Jan 2020 17:57:50 +0100	[thread overview]
Message-ID: <20200124165750.GB15722@pengutronix.de> (raw)
In-Reply-To: <CABDcavb-0dBgxxhzzYLKxrKH_aj9U-+GMmi2CLp-KeAY=ajA6g@mail.gmail.com>

On Mon, Jan 13, 2020 at 09:47:37AM +0100, Guillermo Rodriguez Garcia wrote:
> El dom., 12 ene. 2020 a las 13:52, Michael Olbrich
> (<m.olbrich@pengutronix.de>) escribió:
> >
> > On Tue, Dec 10, 2019 at 07:55:36PM +0100, Guillermo Rodríguez wrote:
> > > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> > > ---
> > >  .../0003-include-sysmacros-for-new-glibc.patch  | 17 +++++++++++++++++
> > >  patches/udev-182/series                         |  1 +
> > >  2 files changed, 18 insertions(+)
> > >  create mode 100644 patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> > >
> > > diff --git a/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> > > new file mode 100644
> > > index 000000000..b2f8db670
> > > --- /dev/null
> > > +++ b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> > > @@ -0,0 +1,17 @@
> > > +Fix build with recent glibc releases where <sys/sysmacros.h> is no
> > > +longer included as part of <sys/types.h>.
> > > +
> > > +Ref.: https://wiki.gentoo.org/wiki/Glibc_2.26_porting_notes/sysmacros.h
> > > +
> > > +Index: udev-182/src/libudev.h
> > > +===================================================================
> >
> > Please provide a proper patch header. Just recreating the patches with
> > git[1] should work.
> 
> I created the patch using quilt as described in the ptxdist
> documentation (https://www.ptxdist.org/doc/dev_manual.html#using-quilt).
> If you don't intend to support this workflow, then I think you should
> cleary state that in the docs.

Indeed, I should add a comment to the docs about this.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2020-01-24 16:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 18:55 Guillermo Rodríguez
2020-01-12 12:52 ` Michael Olbrich
2020-01-13  8:47   ` Guillermo Rodriguez Garcia
2020-01-24 16:57     ` Michael Olbrich [this message]
2020-01-30 13:44       ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200124165750.GB15722@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox