Re: [ptxdist] [PATCH] configure: fix regex for determining host tool versions

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Jan 07, 2020 at 07:40:21PM +0100, Christian Hermann wrote:
> Previously, all of those _VERSION were empty on my system
> 
> Signed-off-by: Christian Hermann <christian.hermann@hytera.de>
> ---
>  configure.ac | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 0549c38da..db2d85f77 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -160,7 +160,7 @@ if test -z "$SED"; then
>  fi
>  
>  AC_MSG_CHECKING([sed version])
> -SED_VERSION=`$SED --version 2>/dev/null | $SED -ne "1 s/.*GNU.*\s\([[0-9\+\.]]\+\).*/\1/p"`
> +SED_VERSION=`$SED --version 2>/dev/null | $SED -ne "1 s/.*GNU.*\s\([0-9\+\.]\+\).*/\1/p"`

This makes no sense. The '[' must be escaped for m4. How does this line
look like in the generated configure script for you? (with and without this
change).

Michael

>  case "$SED_VERSION" in
>  3.*) AC_MSG_ERROR([we need at least GNU sed 4.x but found $SED_VERSION]) ;;
>  4.*) ;;
> @@ -209,7 +209,7 @@ dnl Check for awk
>  AC_PROG_AWK
>  AC_PATH_PROGS(AWK, ${AWK},)
>  AC_MSG_CHECKING([awk version])
> -AWK_VERSION=`$AWK --version 2>/dev/null | $SED -ne "s/GNU [[Aa]]wk \([[0-9\.]]*\)/\1/p"`
> +AWK_VERSION=`$AWK --version 2>/dev/null | $SED -ne "s/GNU [Aa]wk \([0-9\.]*\)/\1/p"`
>  case "$AWK_VERSION" in
>  "") AC_MSG_ERROR([we need GNU awk]) ;;
>  *)  ;;
> @@ -242,7 +242,7 @@ else
>  fi
>  
>  AC_MSG_CHECKING([yacc/bison version])
> -YACC_VERSION=`$YACC --version 2>/dev/null | $SED -ne "s/.*GNU Bison.* \([[0-9.]]*\).*/\1/p"`
> +YACC_VERSION=`$YACC --version 2>/dev/null | $SED -ne "s/.*GNU Bison.* \([0-9.]*\).*/\1/p"`
>  case "${YACC_VERSION}" in
>       1.*)
>       AC_MSG_ERROR([$YACC_VERSION, your bison version is too old, install 2.3 or sth. like that]) ;;
> @@ -283,7 +283,7 @@ if test -z "$WGET"; then
>  fi
>  
>  AC_MSG_CHECKING([find version])
> -FIND_VERSION=`$GNU_find --version 2>/dev/null | $SED -ne "s/.*\s\+\([[0-9]]\+\.[[0-9]]\+\.[[0-9]]\+\).*$/\1/p"`
> +FIND_VERSION=`$GNU_find --version 2>/dev/null | $SED -ne "s/.*\s\+\([0-9]\+\.[0-9]\+\.[0-9]\+\).*$/\1/p"`
>  case "$FIND_VERSION" in
>  4.*) ;;
>  *)   AC_MSG_ERROR([we need at least GNU find 4.x]) ;;
> @@ -295,7 +295,7 @@ AC_PATH_PROGS(MAKE, gmake gnumake make,, $PATH)
>  if test -z "$MAKE"; then
>  	AC_MSG_ERROR([make could not be found, please install])
>  fi
> -MAKE_VERSION=`$MAKE --version 2>/dev/null | $SED -ne "s/^GNU Make \([[0-9]]\+\.[[0-9.]]\+\).*$/\1/p"`
> +MAKE_VERSION=`$MAKE --version 2>/dev/null | $SED -ne "s/^GNU Make \([0-9]\+\.[0-9.]\+\).*$/\1/p"`
>  MINOR_MAKE_VERSION="${MAKE_VERSION#*.}"
>  MAJOR_MAKE_VERSION="${MAKE_VERSION%.*}"
>  if test -z "${MAJOR_MAKE_VERSION}"  -o -z "${MINOR_MAKE_VERSION}" ; then
> @@ -347,7 +347,7 @@ dnl
>  dnl Check for Python 2.x
>  dnl
>  AC_MSG_CHECKING([Python version])
> -PYTHON_VERSION=`$PYTHON --version 2>&1 | $SED -ne "1 s/Python \([[0-9\+\.]]\+\).*/\1/p"`
> +PYTHON_VERSION=`$PYTHON --version 2>&1 | $SED -ne "1 s/Python \([0-9\+\.]\+\).*/\1/p"`
>  case "$PYTHON_VERSION" in
>  2.*) ;;
>  *)   AC_MSG_ERROR([we need Python version 2.x but found $PYTHON_VERSION]) ;;
> -- 
> 2.24.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de