Re: [ptxdist] [ptxdist-commit] 05/06: postgresql: Fix installation of executables.

Re: [ptxdist] [ptxdist-commit] 05/06: postgresql: Fix installation of executables.

[Roland Hieber]

On Tue, Jan 14, 2020 at 09:37:47PM +0100, Michael Olbrich via Gitolite wrote:
> This is an automated email from the git hooks/post-receive script.
> 
> pengutronix.michael.olbrich pushed a commit to branch master
> in repository ptxdist.
> 
> commit e1605f16bc3b205ce25dac8f4bd4a65c3247cd11
> Author: Björn Esser <b.esser@pengutronix.de>
> AuthorDate: Fri Jan 10 10:09:03 2020 +0100
> 
>     postgresql: Fix installation of executables.
>     
>     Signed-off-by: Björn Esser <b.esser@pengutronix.de>
>     [mol: adapt to upstream binary renames]
>     Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---
>  rules/postgresql.make | 48 +++++++++++++++++++++++-------------------------
>  1 file changed, 23 insertions(+), 25 deletions(-)
> 
> diff --git a/rules/postgresql.make b/rules/postgresql.make
> index af3eb6b459a7..b4fe065ac0c6 100644
> --- a/rules/postgresql.make
> +++ b/rules/postgresql.make
> @@ -107,31 +107,29 @@ $(STATEDIR)/postgresql.targetinstall:
>  	@$(call install_lib, postgresql, 0, 0, 0644, libpgtypes)
>  
>  #	# Binaries
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/postgres)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/pg_receivexlog)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/postmaster)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/reindexdb)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/pg_isready)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/pg_dump)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/vacuumdb)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/pg_ctl)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/dropuser)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/createdb)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/createuser)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/initdb)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/pg_restore)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/clusterdb)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/pg_recvlogical)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/pg_resetxlog)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/dropdb)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/ecpg)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/pg_dumpall)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/createlang)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/pg_basebackup)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/psql)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/pg_controldata)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/droplang)
> -	@$(call install_copy, postgresql, 0, 0, 0755, /usr/bin/pg_config)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/postgres)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/pg_receivewal)
> +	@$(call install_lin, postgresql, postgres, /usr/bin/postmaster)

Typo alert: s/install_lin,/install_link,/

 - Roland

> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/reindexdb)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/pg_isready)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/pg_dump)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/vacuumdb)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/pg_ctl)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/dropuser)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/createdb)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/createuser)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/initdb)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/pg_restore)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/clusterdb)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/pg_recvlogical)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/pg_resetwal)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/dropdb)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/ecpg)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/pg_dumpall)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/pg_basebackup)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/psql)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/pg_controldata)
> +	@$(call install_copy, postgresql, 0, 0, 0755, -, /usr/bin/pg_config)
>  
>  #	# This can be further optimized
>  	@$(call install_tree, postgresql, 0, 0, -, /usr/lib/postgresql)
> 
> -- 
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> 
> _______________________________________________
> ptxdist-commit mailing list
> ptxdist-commit@pengutronix.de

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [ptxdist-commit] 05/06: postgresql: Fix installation of executables.

[Michael Olbrich]

On Wed, Jan 15, 2020 at 10:25:55AM +0100, Roland Hieber wrote:
> On Tue, Jan 14, 2020 at 09:37:47PM +0100, Michael Olbrich via Gitolite wrote:
[...]
> > +	@$(call install_lin, postgresql, postgres, /usr/bin/postmaster)
> 
> Typo alert: s/install_lin,/install_link,/

And I was sure I checked that the link was correct... On the bright side,
this motivated me to write a quick and dirty check to find other unknown
macros that are used with 'call' and it's integrated with my other build
tests. So this should not happen again.
On the not so bright side, I found more broken stuff...

Anyways, this should be fixed soon.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de