mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis@linux-mips.org>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH] configure: fix GNU Make version check
Date: Sat, 11 Jan 2020 16:47:52 +0100	[thread overview]
Message-ID: <20200111154752.GA86825@lenoch> (raw)

Currently check for GNU Make version expects only major and minor
number leading to following warning with make-4.2.1:
checking for make... /usr/bin/make
./configure: line 6749: test: 4.2: integer expression expected

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 0549c38da..0b07757b2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -296,8 +296,9 @@ if test -z "$MAKE"; then
 	AC_MSG_ERROR([make could not be found, please install])
 fi
 MAKE_VERSION=`$MAKE --version 2>/dev/null | $SED -ne "s/^GNU Make \([[0-9]]\+\.[[0-9.]]\+\).*$/\1/p"`
+MAJOR_MAKE_VERSION="${MAKE_VERSION%%.*}"
 MINOR_MAKE_VERSION="${MAKE_VERSION#*.}"
-MAJOR_MAKE_VERSION="${MAKE_VERSION%.*}"
+MINOR_MAKE_VERSION="${MINOR_MAKE_VERSION%%.*}"
 if test -z "${MAJOR_MAKE_VERSION}"  -o -z "${MINOR_MAKE_VERSION}" ; then
 	AC_MSG_ERROR([could not parse make version. GNU make >= 3.81 required])
 fi
-- 
2.25.0.rc2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

                 reply	other threads:[~2020-01-11 15:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200111154752.GA86825@lenoch \
    --to=ladis@linux-mips.org \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox