From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ipqML-0006m7-1b for ptxdist@pengutronix.de; Fri, 10 Jan 2020 10:13:37 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1ipqMK-0000OU-QC for ptxdist@pengutronix.de; Fri, 10 Jan 2020 10:13:36 +0100 Date: Fri, 10 Jan 2020 10:13:36 +0100 From: Michael Olbrich Message-ID: <20200110091336.owp6jntqo32233tj@pengutronix.de> References: <20200108154747.29602-1-guille.rodriguez@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200108154747.29602-1-guille.rodriguez@gmail.com> Subject: Re: [ptxdist] [PATCH] Weston: Fix compilation for certain DRM targets List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Wed, Jan 08, 2020 at 04:47:47PM +0100, Guillermo Rodr=EDguez wrote: > If none of LIBDRM_INTEL, LIBDRM_FREEDRENO, or LIBDRM_ETNAVIV is defined, > the simple-dmabuf-drm Meson option is set to an empty list, which breaks > compilation. Fix this by setting the option to 'auto' in this case. > = > Signed-off-by: Guillermo Rodriguez > --- > rules/weston.make | 4 ++++ > 1 file changed, 4 insertions(+) > = > diff --git a/rules/weston.make b/rules/weston.make > index eaabebe61..45b9c6ea6 100644 > --- a/rules/weston.make > +++ b/rules/weston.make > @@ -35,6 +35,10 @@ endif > WESTON_SIMPLE_DMABUF_DRM-$(PTXCONF_WESTON_SIMPLE_DMABUF_DRM_FREEDRENO) += =3D freedreno > WESTON_SIMPLE_DMABUF_DRM-$(PTXCONF_WESTON_SIMPLE_DMABUF_DRM_ETNAVIV) += =3D etnaviv > = > +ifeq ($(WESTON_SIMPLE_DMABUF_DRM-y),) > +WESTON_SIMPLE_DMABUF_DRM-y :=3D auto Hmm, we handle all possible options above, so none should be found with 'auto', so I think the correct setting here is: WESTON_SIMPLE_DMABUF_DRM-y :=3D [] To provide an empty list. Michael > +endif > + > WESTON_SIMPLE_CLIENTS-y :=3D damage im shm touch > WESTON_SIMPLE_CLIENTS-$(PTXCONF_WESTON_GL) +=3D egl dmabuf-egl > = > -- = > 2.21.0 > = > = > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > = -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de