From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v3 2/3] tpm2-tools: version bump 3.1.4 -> 4.1
Date: Mon, 6 Jan 2020 12:24:16 +0100 [thread overview]
Message-ID: <20200106112416.GI5858@pengutronix.de> (raw)
In-Reply-To: <316be637-614d-7512-b7cd-0eb6916d2f6c@pengutronix.de>
On Wed, Dec 18, 2019 at 09:57:24AM +0100, Bastian Krause wrote:
> Hi Bruno,
>
> On 12/17/19 4:16 PM, Bruno Thomsen wrote:
> > Den fre. 29. nov. 2019 kl. 12.52 skrev Bastian Krause <bst@pengutronix.de>:
> >> -TPM2_TOOLS_VERSION := 3.1.4
> >> -TPM2_TOOLS_MD5 := 61b4a382d24c950148a3f5fe41ac2306
> >> +TPM2_TOOLS_VERSION := 4.1
> >
> > I just tested your version bump and found that our build still need
> > a minor change otherwise the prepare stage fails.
> >
> > $ ptxdist prepare tpm2-tools
> >
> > checking whether C compiler accepts -Wall... yes
> > checking whether C compiler accepts -Wextra... yes
> > checking whether C compiler accepts -Werror... yes
> > checking whether C compiler accepts -Wformat... yes
> > checking whether C compiler accepts -Wformat-security... yes
> > checking whether C compiler accepts -Wstack-protector... yes
> > checking whether C compiler accepts -fstack-protector-all... yes
> > checking whether C compiler accepts -Wstrict-overflow=5... yes
> > checking whether C compiler accepts -Wbool-compare... yes
> > checking whether C compiler accepts -O2... yes
> > checking whether to add -D_FORTIFY_SOURCE=2 to CPPFLAGS... yes
> > checking whether C compiler accepts -fPIC... yes
> > checking whether the linker accepts -shared... no
> > configure: error: Cannot enable -shared, consider configuring with
> > --disable-hardening
> >
> >
> > ptxdist platformconfig:
> > #
> > # hardening options
> > #
> > # PTXCONF_TARGET_HARDEN_STACK_NONE is not set
> > # PTXCONF_TARGET_HARDEN_STACK is not set
> > # PTXCONF_TARGET_HARDEN_STACK_STRONG is not set
> > PTXCONF_TARGET_HARDEN_STACK_ALL=y
> > PTXCONF_TARGET_HARDEN_STACKCLASH=y
> > PTXCONF_TARGET_HARDEN_FORTIFY=y
> > PTXCONF_TARGET_HARDEN_RELRO=y
> > PTXCONF_TARGET_HARDEN_BINDNOW=y
> > PTXCONF_TARGET_HARDEN_PIE=y
> > PTXCONF_TARGET_HARDEN_GLIBCXX_ASSERTIONS=y
> >
> > Disabling PIE does not change anything when using arm-v7a-linux-gnueabihf-gcc.
> >
> >> # ----------------------------------------------------------------------------
> >> # Prepare
> >> @@ -34,10 +34,12 @@ TPM2_TOOLS_LICENSE_FILES := file://LICENSE;md5=91b7c548d73ea16537799e8060cea819
> >> TPM2_TOOLS_CONF_TOOL := autoconf
> >> TPM2_TOOLS_CONF_OPT := \
> >> $(CROSS_AUTOCONF_USR) \
> >> + --enable-debug=info \
> >> --disable-code-coverage \
> >> --disable-unit \
> >> --enable-hardening \
> >> - --without-gcov
> >> + --without-gcov \
> >> + --without-bashcompdir
> >
> > TPM2_TOOLS_CFLAGS := \
> > -fPIC
> >
> >
> > I don't know if this is the correct fix or something else is the root cause.
>
> Looks okay to me. Let's wait what Michael has to say about it.
That makes sense to me. I think this should be handled correctly
internally, but I think for a lot if distributions that's already the
default in the toolchain, so it does not fail there.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2020-01-06 11:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 11:51 [ptxdist] [PATCH v3 1/3] tpm2-tss: version bump 2.2.2 -> 2.3.1 Bastian Krause
2019-11-29 11:51 ` [ptxdist] [PATCH v3 2/3] tpm2-tools: version bump 3.1.4 -> 4.1 Bastian Krause
2019-12-17 15:16 ` Bruno Thomsen
2019-12-18 8:57 ` Bastian Krause
2020-01-06 11:24 ` Michael Olbrich [this message]
2020-01-06 14:41 ` Bastian Krause
2020-01-07 14:44 ` Bruno Thomsen
2019-11-29 11:51 ` [ptxdist] [PATCH v3 3/3] tpm2-abrmd: version bump 2.1.1 -> 2.3.0 Bastian Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106112416.GI5858@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox