From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail.pqgruber.com ([52.59.78.55])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <clemens.gruber@pqgruber.com>) id 1in0OF-0001QC-LC
 for ptxdist@pengutronix.de; Thu, 02 Jan 2020 14:19:51 +0100
Received: from workstation.tuxnet (213-47-165-233.cable.dynamic.surfer.at
 [213.47.165.233])
 by mail.pqgruber.com (Postfix) with ESMTPSA id DB4E7C759A1
 for <ptxdist@pengutronix.de>; Thu,  2 Jan 2020 14:19:50 +0100 (CET)
Date: Thu, 2 Jan 2020 14:19:49 +0100
From: Clemens Gruber <clemens.gruber@pqgruber.com>
Message-ID: <20200102131949.GA763@workstation.tuxnet>
References: <20191223144552.93947-1-clemens.gruber@pqgruber.com>
 <3862086864bf5dab3f40b227eb7e5784681b210d.camel@diehl.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <3862086864bf5dab3f40b227eb7e5784681b210d.camel@diehl.com>
Subject: Re: [ptxdist] [PATCH] systemd: install systemd-timesync.list in
 ntp-units.d
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de

Hi Denis,

On Thu, Jan 02, 2020 at 09:46:21AM +0000, Denis OSTERLAND wrote:
> Hi Clemens,
> 
> Am Montag, den 23.12.2019, 15:45 +0100 schrieb Clemens Gruber:
> > When systemd-timesyncd is used, there should be an entry in ntp-units.d.
> > Otherwise, timedatectl set-ntp sometimes fails with "NTP not supported".
> > 
> > Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> > ---
> >  projectroot/usr/lib/systemd/ntp-units.d/80-systemd-timesync.list | 1 +
> >  rules/systemd.make                                               | 1 +
> >  2 files changed, 2 insertions(+)
> >  create mode 100644 projectroot/usr/lib/systemd/ntp-units.d/80-systemd-timesync.list
> > 
> > diff --git a/projectroot/usr/lib/systemd/ntp-units.d/80-systemd-timesync.list b/projectroot/usr/lib/systemd/ntp-units.d/80-systemd-timesync.list
> > new file mode 100644
> > index 000000000..d5959ade8
> > --- /dev/null
> > +++ b/projectroot/usr/lib/systemd/ntp-units.d/80-systemd-timesync.list
> > @@ -0,0 +1 @@
> > +systemd-timesyncd.service
> > diff --git a/rules/systemd.make b/rules/systemd.make
> > index 5564d893f..6b7ec83ab 100644
> > --- a/rules/systemd.make
> > +++ b/rules/systemd.make
> > @@ -432,6 +432,7 @@ ifdef PTXCONF_SYSTEMD_TIMEDATE
> >  		/var/lib/systemd/timesync)
> >  	@$(call install_link, systemd, ../systemd-timesyncd.service,  \
> >  		/usr/lib/systemd/system/sysinit.target.wants/systemd-timesyncd.service)
> > +	@$(call install_tree, systemd, 0, 0, -, /usr/lib/systemd/ntp-units.d/)
> why install_tree and not install_alternative just this file?
> Is there no other valid content of this file?
> Is it unlikely that other packages will install to this directory?

You are right, install_tree is not the right choice, because users
should be able to override it or symlink it to /dev/null.
And other packages like ntpd might supply their own ntp-units.d file,
correct.
I will send a v2 with install_alternative of the
80-systemd-timesync.list file shortly.

Thanks,
Clemens

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de