Hello,

On Fri, Dec 06, 2019 at 11:16:18AM +0100, Michael Olbrich wrote:
> On Thu, Dec 05, 2019 at 10:42:54PM +0100, Alexander Dahl wrote:
> > On Thu, Dec 05, 2019 at 04:19:15PM +0100, Michael Olbrich wrote:
> > > On Fri, Nov 29, 2019 at 10:11:24AM +0100, Alexander Dahl wrote:
> > > > From: Alexander Dahl <ada@thorsis.com>
> > > > 
> > > > This adds the unit testing framework for C called 'cmocka'.
> > > > 
> > > > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> > > > ---
> > > > I tried modifying the opensc package for building its cmocka based
> > > > tests, but autoconf could not find or interpret the pkg-config file
> > > > provided by cmocka. Maybe someone else wants to look deeper into this?  
> > > 
> > > What kind of error do you get there?
> > 
> > I could solve the prepare stage. Seems like pkg-config behaves
> > differently depending on menuconfig settings in ptxdist? What I tried
> > first:
> > 
> > config OPENSC_TESTSUITE                                                    
> >     bool "install testsuite"                                               
> >     depends on CMOCKA                                                      
> > 
> > This gets me the following in
> > ..latform-v7a/build-target/OpenSC-0.19.0/config.log:
> > 
> >  configure:15477: checking for cmocka >= 1.0.1
> >  configure:15484: $PKG_CONFIG --exists --print-errors "cmocka >= 1.0.1"
> >  arm-v7a-linux-gnueabihf-pkg-config: warning: blocking 'cmocka': not selected by 'opensc'
> >  configure:15487: $? = 1
> >  configure:15501: $PKG_CONFIG --exists --print-errors "cmocka >= 1.0.1"
> >  arm-v7a-linux-gnueabihf-pkg-config: warning: blocking 'cmocka': not selected by 'opensc'
> >  configure:15504: $? = 1
> >  configure:15518: result: no
> >  arm-v7a-linux-gnueabihf-pkg-config: warning: blocking 'cmocka': not selected by 'opensc'
> 
> This is expected. With just 'depends on CMOCKA' the build order is
> undefined. So our pkg-configs wrapper explicitly blocks any packages
> without explicit or implicit dependencies. This way, it always fails and
> not just if opensc is built before cmocka.
> 
> > I used the usual 'select CMOCKA if OPENSC_TESTSUITE' then, which
> > succeeds. Alas, I had to add another 'depends on OPENSC_OPENSSL'
> > there. I can send that patch along with a v2 series, beware it won't
> > build, because compilation fails then, because upstream OpenSC did not
> > put a header file they have in their git tree into their tarball …
> 
> :-/

Out of curiosity I tried v0.20.0-rc4 and hat one builds successfully.
However I don't use that package by myself, so anyone else should test
that after OpenSC releases 0.20.0 eventually.

Other projects using CMocka: libssh, openvpn, samba, … maybe that
package authors also want to test it with CMocka by themselves then?

Greets
Alex

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)