From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Date: Sat, 7 Dec 2019 13:27:35 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20191207122735.pnplulv7yk4kvg6v@pengutronix.de>
References: <20191206180244.5637-1-bruno.thomsen@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20191206180244.5637-1-bruno.thomsen@gmail.com>
Subject: Re: [ptxdist] [PATCH] u-boot: bugfix: trigger recompile on Kconfig
 changes
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>, bth@kamstrup.com

On Fri, Dec 06, 2019 at 07:02:44PM +0100, Bruno Thomsen wrote:
> When using the modern Kconfig as config system, changes to
> the config file did not trigger a rebuild of the image.
> 
> Steps to reproduce:
> $ ptxdist targetinstall u-boot
>  <image is build>
> $ ptxdist menuconfig u-boot
>  <change any option>
> $ ptxdist targetinstall u-boot
>  <all up-to-date>

With which ptxdist version? I cannot reproduce this with master.
Changes to the config file change the u-boot.*.cfghash and trigger the
rebuild.

Michael

> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
>  rules/u-boot.make | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/u-boot.make b/rules/u-boot.make
> index 04d801fc6..4a4bd3f85 100644
> --- a/rules/u-boot.make
> +++ b/rules/u-boot.make
> @@ -30,6 +30,7 @@ U_BOOT_BUILD_OOT	:= KEEP
>  ifdef PTXCONF_U_BOOT_CONFIGSYSTEM_KCONFIG
>  U_BOOT_CONFIG	:= $(call ptx/in-platformconfigdir, \
>  		$(call remove_quotes, $(PTXCONF_U_BOOT_CONFIGFILE_KCONFIG)))
> +$(STATEDIR)/u-boot.compile: $(U_BOOT_CONFIG)
>  endif
>  
>  # ----------------------------------------------------------------------------
> -- 
> 2.23.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de