From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>, bth@kamstrup.com
Subject: Re: [ptxdist] [PATCH] u-boot: bugfix: trigger recompile on Kconfig changes
Date: Sat, 7 Dec 2019 13:27:35 +0100 [thread overview]
Message-ID: <20191207122735.pnplulv7yk4kvg6v@pengutronix.de> (raw)
In-Reply-To: <20191206180244.5637-1-bruno.thomsen@gmail.com>
On Fri, Dec 06, 2019 at 07:02:44PM +0100, Bruno Thomsen wrote:
> When using the modern Kconfig as config system, changes to
> the config file did not trigger a rebuild of the image.
>
> Steps to reproduce:
> $ ptxdist targetinstall u-boot
> <image is build>
> $ ptxdist menuconfig u-boot
> <change any option>
> $ ptxdist targetinstall u-boot
> <all up-to-date>
With which ptxdist version? I cannot reproduce this with master.
Changes to the config file change the u-boot.*.cfghash and trigger the
rebuild.
Michael
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> rules/u-boot.make | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/rules/u-boot.make b/rules/u-boot.make
> index 04d801fc6..4a4bd3f85 100644
> --- a/rules/u-boot.make
> +++ b/rules/u-boot.make
> @@ -30,6 +30,7 @@ U_BOOT_BUILD_OOT := KEEP
> ifdef PTXCONF_U_BOOT_CONFIGSYSTEM_KCONFIG
> U_BOOT_CONFIG := $(call ptx/in-platformconfigdir, \
> $(call remove_quotes, $(PTXCONF_U_BOOT_CONFIGFILE_KCONFIG)))
> +$(STATEDIR)/u-boot.compile: $(U_BOOT_CONFIG)
> endif
>
> # ----------------------------------------------------------------------------
> --
> 2.23.0
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2019-12-07 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 18:02 Bruno Thomsen
2019-12-07 12:27 ` Michael Olbrich [this message]
2019-12-09 7:34 ` Bruno Thomsen
2019-12-10 9:30 ` Bruno Thomsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191207122735.pnplulv7yk4kvg6v@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=bruno.thomsen@gmail.com \
--cc=bth@kamstrup.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox