mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2 2/2] opensc: Reactivate testsuite option
Date: Fri, 6 Dec 2019 11:17:03 +0100	[thread overview]
Message-ID: <20191206101703.thxx2xwfjuociyr6@pengutronix.de> (raw)
In-Reply-To: <20191205215921.6854-3-post@lespocky.de>

On Thu, Dec 05, 2019 at 10:59:21PM +0100, Alexander Dahl wrote:
> This allows to run prepare stage successfully, cmocka is found now, but
> compile stage fails with opensc 0.19.0 because apparently a header file
> 'p11test_common.h' which is present in opensc git tree is missing in the
> tarball …
> 
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
>  rules/opensc.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/opensc.in b/rules/opensc.in
> index eeda1e43d..6ebe64cf8 100644
> --- a/rules/opensc.in
> +++ b/rules/opensc.in
> @@ -7,6 +7,7 @@ menuconfig OPENSC
>  	select OPENCT		if OPENSC_OPENCT
>  	select PCSC_LITE	if OPENSC_PCSC
>  	select OPENSSL		if OPENSC_OPENSSL
> +	select CMOCKA		if OPENSC_TESTSUITE
>  	help
>  	  Smart card utilities with support for PKCS#15 compatible cards
>  
> @@ -44,8 +45,7 @@ config OPENSC_TOOLS
>  	bool "install tools"
>  
>  config OPENSC_TESTSUITE
> -	# needs cmocka
> -	depends on BROKEN
>  	bool "install testsuite"
> +	depends on OPENSC_OPENSSL

I'd prefer a 'select OPENSC_OPENSSL' here.

Michael

>  
>  endif
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2019-12-06 10:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05 21:59 [ptxdist] [PATCH v2 0/2] cmocka and packages depending on it Alexander Dahl
2019-12-05 21:59 ` [ptxdist] [PATCH v2 1/2] cmocka: new package Alexander Dahl
2019-12-05 21:59 ` [ptxdist] [PATCH v2 2/2] opensc: Reactivate testsuite option Alexander Dahl
2019-12-06 10:17   ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191206101703.thxx2xwfjuociyr6@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox