From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: From: Roland Hieber Date: Wed, 27 Nov 2019 15:10:51 +0100 Message-Id: <20191127141051.20699-1-rhi@pengutronix.de> MIME-Version: 1.0 Subject: [ptxdist] [PATCH] bash_completion: use '_have' instead of 'have' List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de Cc: Roland Hieber 'have' was deprecated upstream about 8 years ago. [0] Also, since it is only available inside of /etc/bash_completion [1], using it makes it harder to (re)load existing completions in a running shell: $ . ~/.bash_completion.d/ptxdist bash: have: command not found Use '_have' instead, which does not have these problems. [0]: https://github.com/scop/bash-completion/commit/20c05b43b6e44b [1]: https://github.com/scop/bash-completion/blob/31b5cbc8016b18/bash_completion#L2158 Signed-off-by: Roland Hieber --- scripts/bash_completion | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/bash_completion b/scripts/bash_completion index e0dd3428455c..deb14ad0cb8a 100644 --- a/scripts/bash_completion +++ b/scripts/bash_completion @@ -5,7 +5,7 @@ # part of PTXdist, so same licence. # -if have ptxdist; then +if _have ptxdist; then declare -a _ptxdist_completion_opts declare -a _ptxdist_completion_cmds -- 2.24.0 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de