mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] bash_completion: use '_have' instead of 'have'
@ 2019-11-27 14:10 Roland Hieber
  0 siblings, 0 replies; only message in thread
From: Roland Hieber @ 2019-11-27 14:10 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

'have' was deprecated upstream about 8 years ago. [0] Also, since it is
only available inside of /etc/bash_completion [1], using it makes it
harder to (re)load existing completions in a running shell:

    $ . ~/.bash_completion.d/ptxdist
    bash: have: command not found

Use '_have' instead, which does not have these problems.

[0]: https://github.com/scop/bash-completion/commit/20c05b43b6e44b
[1]: https://github.com/scop/bash-completion/blob/31b5cbc8016b18/bash_completion#L2158

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 scripts/bash_completion | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/bash_completion b/scripts/bash_completion
index e0dd3428455c..deb14ad0cb8a 100644
--- a/scripts/bash_completion
+++ b/scripts/bash_completion
@@ -5,7 +5,7 @@
 # part of PTXdist, so same licence.
 #
 
-if have ptxdist; then
+if _have ptxdist; then
 
 declare -a _ptxdist_completion_opts
 declare -a _ptxdist_completion_cmds
-- 
2.24.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-11-27 14:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 14:10 [ptxdist] [PATCH] bash_completion: use '_have' instead of 'have' Roland Hieber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox