From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] python3-numpy: New package
Date: Tue, 19 Nov 2019 10:23:22 +0100 [thread overview]
Message-ID: <20191119092322.evmeue6xhaxcf4wm@pengutronix.de> (raw)
In-Reply-To: <CABDcavYBvh-_0xj3B4sJaR3PgwpF_jkSf6er=Xarse_3v0xb3A@mail.gmail.com>
Hi,
On Tue, Nov 19, 2019 at 10:10:09AM +0100, Guillermo Rodriguez Garcia wrote:
> El vie., 15 nov. 2019 a las 21:11, Guillermo Rodriguez Garcia
> (<guille.rodriguez@gmail.com>) escribió:
> > El viernes, 15 de noviembre de 2019, Michael Olbrich <m.olbrich@pengutronix.de> escribió:
> >> On Fri, Nov 15, 2019 at 09:51:25AM +0100, Guillermo Rodríguez wrote:
> >> > NumPy is the fundamental package for scientific computing with Python.
> >> >
> >> > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> >> > ---
> >> > v2: Switch to PyPi URL; this removes the dependency on Cython.
> >> > v3: Update LICENSE, add LICENSE_FILES
> >> > v4: Update LICENSE and LICENSE_FILES with additional licenses
> >> > v5: Removed "unknown" from LICENSE
> >> > v6: Updated to 1.17.4, added patch to fix cross compilation
> >> >
> >> > .../numpy-1.17.4/0001-remove-sse2-flag.patch | 21 +++++++
> >> > patches/numpy-1.17.4/series | 1 +
> >> > rules/python3-numpy.in | 10 ++++
> >> > rules/python3-numpy.make | 57 +++++++++++++++++++
> >> > 4 files changed, 89 insertions(+)
> >> > create mode 100644 patches/numpy-1.17.4/0001-remove-sse2-flag.patch
> >> > create mode 100644 patches/numpy-1.17.4/series
> >> > create mode 100644 rules/python3-numpy.in
> >> > create mode 100644 rules/python3-numpy.make
> >> >
> >> > diff --git a/patches/numpy-1.17.4/0001-remove-sse2-flag.patch b/patches/numpy-1.17.4/0001-remove-sse2-flag.patch
> >> > new file mode 100644
> >> > index 000000000..e1cb0d878
> >> > --- /dev/null
> >> > +++ b/patches/numpy-1.17.4/0001-remove-sse2-flag.patch
> >> > @@ -0,0 +1,21 @@
> >> > +Fix cross-compilation for non-Intel targets.
> >> > +See: https://github.com/numpy/numpy/issues/14861
> >> > +
> >> > +---
> >>
> >> Please create a proper patch header.
> >>
> >>
> >
> > Can you please let me know what is wrong specifically? The patch was
> > generated by quilt and I just added the comment in the first two lines.
> >
> > I'd prefer to fix whatever is wrong in the patch header rather than
> > regenerate the patch using a different method.
>
> Waiting for feedback on this one in order to generate a new version
> that would fix the patch header and remove the explicit
> HOST_PYTHON3_SETUPTOOLS dependency.
In general, I'd like to see the From:, Date:, Subject: headers created by
git. In this specific case, now that it is fixed upstream, I prefer the
exact patch from upstream (including these headers) and with an added
comment, that it's ab backport from upstream. That helps when the packages
is updated to a new version.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2019-11-19 9:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 15:13 Guillermo Rodríguez
2019-11-12 9:32 ` [ptxdist] [PATCH v2] " Guillermo Rodríguez
2019-11-12 9:51 ` [ptxdist] [PATCH] " Roland Hieber
2019-11-12 11:48 ` Guillermo Rodriguez Garcia
2019-11-12 11:51 ` [ptxdist] [PATCH v3] " Guillermo Rodríguez
2019-11-13 9:36 ` Roland Hieber
2019-11-14 9:36 ` Guillermo Rodriguez Garcia
2019-11-14 9:56 ` Roland Hieber
2019-11-14 10:01 ` Guillermo Rodriguez Garcia
2019-11-14 10:03 ` [ptxdist] [PATCH v4] " Guillermo Rodríguez
2019-11-14 10:07 ` [ptxdist] [PATCH v3] " Guillermo Rodriguez Garcia
2019-11-14 10:09 ` [ptxdist] [PATCH v5] " Guillermo Rodríguez
2019-11-14 20:24 ` Ladislav Michl
2019-11-14 11:18 ` [ptxdist] [PATCH v3] " Roland Hieber
2019-11-14 11:40 ` Guillermo Rodriguez Garcia
2019-11-14 13:31 ` Roland Hieber
2019-11-14 18:50 ` Guillermo Rodriguez Garcia
2019-11-15 8:51 ` [ptxdist] [PATCH v6] " Guillermo Rodríguez
2019-11-15 14:19 ` Michael Olbrich
2019-11-15 20:11 ` [ptxdist] [PATCH] " Guillermo Rodriguez Garcia
2019-11-19 9:10 ` Guillermo Rodriguez Garcia
2019-11-19 9:23 ` Michael Olbrich [this message]
2019-11-19 10:15 ` Guillermo Rodriguez Garcia
2019-11-19 12:39 ` [ptxdist] [PATCH v7] " Guillermo Rodríguez
2019-11-25 6:32 ` Michael Olbrich
2019-11-25 9:35 ` Guillermo Rodriguez Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119092322.evmeue6xhaxcf4wm@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox