From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eddie.linux-mips.org ([148.251.95.138] helo=cvs.linux-mips.org) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1iWoNJ-0007dn-N7 for ptxdist@pengutronix.de; Mon, 18 Nov 2019 22:15:58 +0100 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23993083AbfKRVPzUpq2R (ORCPT ); Mon, 18 Nov 2019 22:15:55 +0100 Date: Mon, 18 Nov 2019 22:15:54 +0100 From: Ladislav Michl Message-ID: <20191118211554.GA167118@lenoch> References: <20191025073326.GB26830@lenoch> <20191025073426.GC26830@lenoch> <20191025075559.GF30823@pengutronix.de> <20191025230928.GA30150@lenoch> <20191027063051.ai6l5hq57j2czfk3@pengutronix.de> <20191115191924.GA22406@lenoch> <20191116100847.oxgzmycabkeoxfjh@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191116100847.oxgzmycabkeoxfjh@pengutronix.de> Subject: Re: [ptxdist] [PATCH 1/2] add scons conf tool List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Sat, Nov 16, 2019 at 11:08:47AM +0100, Michael Olbrich wrote: > On Fri, Nov 15, 2019 at 08:19:24PM +0100, Ladislav Michl wrote: > > On Sun, Oct 27, 2019 at 07:30:51AM +0100, Michael Olbrich wrote: > > > On Sat, Oct 26, 2019 at 01:09:28AM +0200, Ladislav Michl wrote: [...] > > > > See quick attempt bellow. Problem with SCons is that install stage > > > > has to be called with exactly the same env as build stage, otherwise > > > > package is rebuild. Alternatively we can leave everything to install > > > > stage. > > > > > > This looks good. Or maybe just drop pkg_install_env. It's deprecated > > > > Seems patch was modified to run scons at compile stage as well. What is > > the justification of such a change? > > Compiling should happen in the compile stage. Otherwise, thinks like > parallel building does not work correctly. It does not work correctly yet > for scons because I need to sanitize the parallel building options for > non-make tools, but that's on my todo list. Fair enough although now commit message does not reflect code :) > And I looked at gpsd. Scons is not the reason why stuff is rebuild during > install: There is a header that is recreated every time scons is called > :-/. Well, scons runs config stage each time some target is called :-/ (that's why compile and install env settings has to be the same). ladis _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de