From: Ladislav Michl <ladis@linux-mips.org>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/2] add scons conf tool
Date: Mon, 18 Nov 2019 22:15:54 +0100 [thread overview]
Message-ID: <20191118211554.GA167118@lenoch> (raw)
In-Reply-To: <20191116100847.oxgzmycabkeoxfjh@pengutronix.de>
On Sat, Nov 16, 2019 at 11:08:47AM +0100, Michael Olbrich wrote:
> On Fri, Nov 15, 2019 at 08:19:24PM +0100, Ladislav Michl wrote:
> > On Sun, Oct 27, 2019 at 07:30:51AM +0100, Michael Olbrich wrote:
> > > On Sat, Oct 26, 2019 at 01:09:28AM +0200, Ladislav Michl wrote:
[...]
> > > > See quick attempt bellow. Problem with SCons is that install stage
> > > > has to be called with exactly the same env as build stage, otherwise
> > > > package is rebuild. Alternatively we can leave everything to install
> > > > stage.
> > >
> > > This looks good. Or maybe just drop pkg_install_env. It's deprecated
> >
> > Seems patch was modified to run scons at compile stage as well. What is
> > the justification of such a change?
>
> Compiling should happen in the compile stage. Otherwise, thinks like
> parallel building does not work correctly. It does not work correctly yet
> for scons because I need to sanitize the parallel building options for
> non-make tools, but that's on my todo list.
Fair enough although now commit message does not reflect code :)
> And I looked at gpsd. Scons is not the reason why stuff is rebuild during
> install: There is a header that is recreated every time scons is called
> :-/.
Well, scons runs config stage each time some target is called :-/ (that's
why compile and install env settings has to be the same).
ladis
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2019-11-18 21:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 7:33 [ptxdist] [PATCH 0/2] add scons conf tool and let gpsd to use it Ladislav Michl
2019-10-25 7:34 ` [ptxdist] [PATCH 1/2] add scons conf tool Ladislav Michl
2019-10-25 7:55 ` Michael Olbrich
2019-10-25 23:09 ` Ladislav Michl
2019-10-27 6:30 ` Michael Olbrich
2019-11-15 19:19 ` Ladislav Michl
2019-11-16 10:08 ` Michael Olbrich
2019-11-18 21:15 ` Ladislav Michl [this message]
2019-10-25 7:35 ` [ptxdist] [PATCH 2/2] gpsd: version bump 2.39 -> 3.19 Ladislav Michl
2019-10-25 8:16 ` Michael Olbrich
2019-10-25 13:17 ` [ptxdist] [PATCH v2] " Ladislav Michl
2019-10-25 13:38 ` Michael Olbrich
2019-10-25 13:58 ` Ladislav Michl
2019-10-25 23:13 ` [ptxdist] [PATCH v3] " Ladislav Michl
2019-10-27 6:22 ` Michael Olbrich
2019-10-27 16:25 ` Michael Olbrich
2019-10-27 22:29 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118211554.GA167118@lenoch \
--to=ladis@linux-mips.org \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox