Re: [ptxdist] [PATCH v3] python3-numpy: New package

[Roland Hieber <rhi@pengutronix.de>]

On Thu, Nov 14, 2019 at 11:07:16AM +0100, Guillermo Rodriguez Garcia wrote:
> El jue., 14 nov. 2019 a las 10:56, Roland Hieber (<rhi@pengutronix.de>)
> escribió:
> 
> > > > numpy/core/src/multiarray/dragon4.c seems to be a license found nowhere
> > > > else, so I would also add "AND UNKNOWN" to PYTHON3_NUMPY_LICENSE and
> > add
> > > > its verbatim license text with startline and endline parameters in
> > > > PYTHON3_NUMPY_LICENSE_FILES. PTXdist extracts all those license
> > > > texts mentioned in that variable and adds them to the license report,
> > > > so it doesn't get lost too :)
> >
> 
> On re-reading this: The license in dragon4.c is just MIT. So while it is OK
> to add it to LICENSE_FILES I think we should not add the "AND unknown" bit.

Oh. I just blindly believed LICENSE.txt. But now that you say it, my
license matcher identifies it as "Zlib", not as "MIT".

> I am sending v5, sorry for the noise.

No problem, that's what review is for, and thanks for your patience  :)

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de