From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iNtyW-0003dy-JK for ptxdist@pengutronix.de; Fri, 25 Oct 2019 09:25:32 +0200 Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1iNtyW-0004e9-BN for ptxdist@pengutronix.de; Fri, 25 Oct 2019 09:25:32 +0200 Date: Fri, 25 Oct 2019 09:25:32 +0200 From: Michael Olbrich Message-ID: <20191025072532.GC30823@pengutronix.de> References: <20190911150528.2374-1-bst@pengutronix.de> <20190911150528.2374-4-bst@pengutronix.de> <20190912152610.zmzwycjwmplywr2o@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190912152610.zmzwycjwmplywr2o@pengutronix.de> Subject: Re: [ptxdist] [PATCH 4/4] sshfs: add license information List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Thu, Sep 12, 2019 at 05:26:10PM +0200, Roland Hieber wrote: > On Wed, Sep 11, 2019 at 05:05:28PM +0200, Bastian Krause wrote: > > Signed-off-by: Bastian Krause > > --- > > rules/sshfs.make | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/rules/sshfs.make b/rules/sshfs.make > > index 919e3b8e1..d5a743337 100644 > > --- a/rules/sshfs.make > > +++ b/rules/sshfs.make > > @@ -21,7 +21,8 @@ SSHFS_SUFFIX := tar.xz > > SSHFS_URL := https://github.com/libfuse/sshfs/releases/download/$(SSHFS)/$(SSHFS).$(SSHFS_SUFFIX) > > SSHFS_SOURCE := $(SRCDIR)/$(SSHFS).$(SSHFS_SUFFIX) > > SSHFS_DIR := $(BUILDDIR)/$(SSHFS) > > -SSHFS_LICENSE := unknown > > +SSHFS_LICENSE := GPL-2.0-or-later > > +SSHFS_LICENSE_FILES := file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 > > This one is interesting. The headers in the source files only read: > > This program can be distributed under the terms of the GNU GPL. > See the file COPYING. > > The GPL version in ./COPYING is a 2.0 and reads in article 9: > > 242 | Each version is given a distinguishing version number. If the Program > 243 | specifies a version number of this License which applies to it and "any > 244 | later version", you have the option of following the terms and conditions > 245 | either of that version or of any later version published by the Free > 246 | Software Foundation. If the Program does not specify a version number of > 247 | this License, you may choose any version ever published by the Free Software > 248 | Foundation. > > (line numbers inserted for reference). > > So we can indeed use GPL-2.0-or-later here. 'any version' would also include GPL-1.0 right? And I'm not sure if that was the intention of the author. Also, I could argue that having GPL-2.0 in the COPYING file is a way of specifying the version number. So I'd prefer GPL-2.0-only. That might be more restrictive than necessary but it's still correct either way. Michael > The rest of the series looks good to me after a short look through the > respective code bases, so for the whole series: > > * [PATCH 1/4] host-meson: add license information > * [PATCH 2/4] host-softhsm: add license information > * [PATCH 3/4] slang: add license information > * [PATCH 4/4] sshfs: add license information > > Reviewed-by: Roland Hieber > > -- > Roland Hieber | r.hieber@pengutronix.de | > Pengutronix e.K. | https://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de