[ptxdist] [PATCH] kernel: do not select binutils

[ptxdist] [PATCH] kernel: do not select binutils

[Bastian Krause]

binutils is not used in perf tools (anymore?), so do not select it.

Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
 rules/kernel.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/rules/kernel.in b/rules/kernel.in
index 817481577..4d264c8ba 100644
--- a/rules/kernel.in
+++ b/rules/kernel.in
@@ -5,7 +5,6 @@ menuconfig KERNEL
 	select LIBELF		if KERNEL_TOOL_PERF
 	select LIBELF_LIBDW	if KERNEL_TOOL_PERF
 	select SLANG		if KERNEL_TOOL_PERF
-	select BINUTILS		if KERNEL_TOOL_PERF
 	select LIBUNWIND	if KERNEL_TOOL_PERF
 
 if KERNEL
-- 
2.23.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] kernel: do not select binutils

[Roland Hieber]

On Wed, Sep 11, 2019 at 05:06:01PM +0200, Bastian Krause wrote:
> binutils is not used in perf tools (anymore?), so do not select it.
> 
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
>  rules/kernel.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/rules/kernel.in b/rules/kernel.in
> index 817481577..4d264c8ba 100644
> --- a/rules/kernel.in
> +++ b/rules/kernel.in
> @@ -5,7 +5,6 @@ menuconfig KERNEL
>  	select LIBELF		if KERNEL_TOOL_PERF
>  	select LIBELF_LIBDW	if KERNEL_TOOL_PERF
>  	select SLANG		if KERNEL_TOOL_PERF
> -	select BINUTILS		if KERNEL_TOOL_PERF
>  	select LIBUNWIND	if KERNEL_TOOL_PERF

This depends on which kernel version you use in the platformconfig.
Could you find out since when binutils is no longer needed?

 - Roland


-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] kernel: do not select binutils

[Michael Olbrich]

On Thu, Sep 12, 2019 at 05:05:37PM +0200, Roland Hieber wrote:
> On Wed, Sep 11, 2019 at 05:06:01PM +0200, Bastian Krause wrote:
> > binutils is not used in perf tools (anymore?), so do not select it.
> > 
> > Signed-off-by: Bastian Krause <bst@pengutronix.de>
> > ---
> >  rules/kernel.in | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/rules/kernel.in b/rules/kernel.in
> > index 817481577..4d264c8ba 100644
> > --- a/rules/kernel.in
> > +++ b/rules/kernel.in
> > @@ -5,7 +5,6 @@ menuconfig KERNEL
> >  	select LIBELF		if KERNEL_TOOL_PERF
> >  	select LIBELF_LIBDW	if KERNEL_TOOL_PERF
> >  	select SLANG		if KERNEL_TOOL_PERF
> > -	select BINUTILS		if KERNEL_TOOL_PERF
> >  	select LIBUNWIND	if KERNEL_TOOL_PERF
> 
> This depends on which kernel version you use in the platformconfig.
> Could you find out since when binutils is no longer needed?

Sorry, that was my fault. I checked on BSP and noticed that libbfd was not
actually used so I suggested this. And I've used perf in this project
without noticing any missing feature.

However, with another BSP libbfd is actually found. I've don't know what
the difference is.

I've also looked at the code. It seems libbfd is used for 'addr2line()'.
Does anyone know what this is for? The fallback (if libbfd is not found) is
to call the 'addr2line' program (not installed by ptxdist either).

So, should we keep the dependency (and fix it as needed) or drop it?

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de