Re: [ptxdist] [PATCH] perl: Add patch for compatibility with recent libcrypt implementations.

[Alexander Dahl <post@lespocky.de>]

[-- Attachment #1.1: Type: text/plain, Size: 2439 bytes --]

Hei hei,

this is slightly offtopic, but let me answer anyways …

On Thu, Oct 10, 2019 at 02:45:03PM +0200, Björn Esser wrote:
> On Do, 2019-10-10 at 14:39 +0200, Roland Hieber wrote:
> > On Thu, Oct 10, 2019 at 10:44:45AM +0200, Björn Esser wrote:
> > > Signed-off-by: Björn Esser <b.esser@pengutronix.de>
> > > ---
> > >  .../0001-It-s-lpthread-not-lpthreads.patch    |  7 +++-
> > >  ...-fix-build-failure-with-recent-glibc.patch | 39
> > > +++++++++++++++++++
> > >  patches/perl-5.18.2/series                    |  3 +-
> > >  3 files changed, 47 insertions(+), 2 deletions(-)
> > >  create mode 100644 patches/perl-5.18.2/0002-fix-build-failure-
> > > with-recent-glibc.patch
> > > 
> > > diff --git a/patches/perl-5.18.2/0001-It-s-lpthread-not-
> > > lpthreads.patch b/patches/perl-5.18.2/0001-It-s-lpthread-not-
> > > lpthreads.patch
> > > index 319cefb2e..7a7bb1beb 100644
> > > --- a/patches/perl-5.18.2/0001-It-s-lpthread-not-lpthreads.patch
> > > +++ b/patches/perl-5.18.2/0001-It-s-lpthread-not-lpthreads.patch
> > > @@ -1,15 +1,20 @@
> > >  From: Michael Olbrich <m.olbrich@pengutronix.de>
> > >  Date: Wed, 23 Apr 2014 09:02:25 +0200
> > >  Subject: [PATCH] It's -lpthread not -lpthreads
> > > +MIME-Version: 1.0
> > > +Content-Type: text/plain; charset=UTF-8
> > > +Content-Transfer-Encoding: 8bit
> > 
> > Hmm, I wonder how you got these additional headers? :-)
> > 
> >  - Roland
> 
> 
> Git adds them, when you have signoff enabled globally in your
> gitconfig…

Not exactly. Git adds those on `git format-patch` if the commit
message in your patch contains other characters than 7 bit us-ascii.
In this case there's an 'ö' in the name in the s-o-b line. This is
also what happens if you recreate a patch series in ptxdist with
`git ptx-patches` and one of the commit messages contains stuff
encoded in utf-8 which does not fit in us-ascii.

You also get such lines if the content (not the commit message) of
your patch contains 8-bit chars and you send it with `git send-email`.
Git (2.20) does not add those lines to the patch on `git format-patch`
though.

Greets
Alex

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 92 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de