[ptxdist] [PATCH 0/2] libnl3: version bump 3.4.0 -> 3.5.0 and license fix

[ptxdist] [PATCH 0/2] libnl3: version bump 3.4.0 -> 3.5.0 and license fix

[Andreas Pretzsch]

Split in two patches, to keep license change clearly visible in history.
To me, the license tag update looks legit, but please review and decide.
For details, see commit comment.

The version bump itself should be fine. Short test done here on a quite
up-to-date system (kernel 5.3) with iw and tcpdump.

Andreas Pretzsch (2):
  libnl3: version bump 3.4.0 -> 3.5.0
  libnl3: fix license identifier (GPL-2.0-only -> LGPL-2.1-only)

 rules/libnl3.make | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.19.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH 1/2] libnl3: version bump 3.4.0 -> 3.5.0

[Andreas Pretzsch]

Update from libnl 3.4.0 (Oct 2017) to latest 3.5.0 (Sep 2019).

On a first glance, just a lot of fixes and some added features.
Plus updated copies and new imports of kernel headers (4.19.66).

Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
---
 rules/libnl3.make | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rules/libnl3.make b/rules/libnl3.make
index 5b664f37b..153c7b80e 100644
--- a/rules/libnl3.make
+++ b/rules/libnl3.make
@@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_LIBNL3) += libnl3
 #
 # Paths and names
 #
-LIBNL3_VERSION	:= 3.4.0
-LIBNL3_MD5	:= 8f71910c03db363b41e2ea62057a4311
+LIBNL3_VERSION	:= 3.5.0
+LIBNL3_MD5	:= 74ba57b1b1d6f9f92268aa8141d8e8e4
 LIBNL3		:= libnl-$(LIBNL3_VERSION)
 LIBNL3_RELEASE	:= libnl$(subst .,_,$(LIBNL3_VERSION))
 LIBNL3_SUFFIX	:= tar.gz
-- 
2.19.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH 2/2] libnl3: fix license identifier (GPL-2.0-only -> LGPL-2.1-only)

[Andreas Pretzsch]

One of the changes 3.4.0 -> 3.5.0 was to add SPDX tags all
across the source files. They are now tagged as LGPL-2.1-only.

The lib code itself had written LGPL-2.1-only headers already,
as did most of the commandline tools (src/nf-* and src/nl-*).
Very few of the cli tools have written GPL-2.0-only headers
even now, but the LGPL-2.1-only SPDX tag was added there also.
But given the use of those cli tools, and the meaning of LGPL
for regular executables, they are probably fine as LGPL, too.

For details, see https://github.com/thom311/libnl/pull/219
It was accepted mainline as commit cee0b1b 'Add SPDX identifiers'.

Therefore update the license tag in the rule to follow mainline.

Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
---
 rules/libnl3.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/libnl3.make b/rules/libnl3.make
index 153c7b80e..5b3af0065 100644
--- a/rules/libnl3.make
+++ b/rules/libnl3.make
@@ -22,7 +22,7 @@ LIBNL3_SUFFIX	:= tar.gz
 LIBNL3_URL	:= https://github.com/thom311/libnl/releases/download/$(LIBNL3_RELEASE)/$(LIBNL3).$(LIBNL3_SUFFIX)
 LIBNL3_SOURCE	:= $(SRCDIR)/$(LIBNL3).$(LIBNL3_SUFFIX)
 LIBNL3_DIR	:= $(BUILDDIR)/$(LIBNL3)
-LIBNL3_LICENSE	:= GPL-2.0-only
+LIBNL3_LICENSE	:= LGPL-2.1-only
 
 #
 # autoconf
-- 
2.19.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH 2/2] libnl3: fix license identifier (GPL-2.0-only -> LGPL-2.1-only)

[Roland Hieber]

On Tue, Oct 08, 2019 at 10:01:50PM +0200, Andreas Pretzsch wrote:
> One of the changes 3.4.0 -> 3.5.0 was to add SPDX tags all
> across the source files. They are now tagged as LGPL-2.1-only.
> 
> The lib code itself had written LGPL-2.1-only headers already,
> as did most of the commandline tools (src/nf-* and src/nl-*).
> Very few of the cli tools have written GPL-2.0-only headers
> even now, but the LGPL-2.1-only SPDX tag was added there also.
> But given the use of those cli tools, and the meaning of LGPL
> for regular executables, they are probably fine as LGPL, too.
> 
> For details, see https://github.com/thom311/libnl/pull/219
> It was accepted mainline as commit cee0b1b 'Add SPDX identifiers'.
> 
> Therefore update the license tag in the rule to follow mainline.
> 
> Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> ---
>  rules/libnl3.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/libnl3.make b/rules/libnl3.make
> index 153c7b80e..5b3af0065 100644
> --- a/rules/libnl3.make
> +++ b/rules/libnl3.make
> @@ -22,7 +22,7 @@ LIBNL3_SUFFIX	:= tar.gz
>  LIBNL3_URL	:= https://github.com/thom311/libnl/releases/download/$(LIBNL3_RELEASE)/$(LIBNL3).$(LIBNL3_SUFFIX)
>  LIBNL3_SOURCE	:= $(SRCDIR)/$(LIBNL3).$(LIBNL3_SUFFIX)
>  LIBNL3_DIR	:= $(BUILDDIR)/$(LIBNL3)
> -LIBNL3_LICENSE	:= GPL-2.0-only
> +LIBNL3_LICENSE	:= LGPL-2.1-only

It's also a good idea to add 
LIBNL3_LICENSE_FILES    := file://COPYING;md5=4fbd65380cdd255951079008b364516c
so we get a hint where the license is and when it changes again.

I threw licensecheck [1] at the code. There a few files which have
comments identifying them as GPL-2.0-only, but also now have a
"SPDX-License-Identifier: LGPL-2.1-only" tag:

./src/idiag-socket-details.c	GPL (v2)
./src/nl-addr-add.c	GPL (v2)
./src/nl-addr-delete.c	GPL (v2)
./src/nl-addr-list.c	GPL (v2)
./src/nl-cls-add.c	GPL (v2)

as well as several files in ./include/linux-private/linux/, which are
GPL-2.0 WITH Linux-syscall-note or GPL-2.0+ WITH Linux-syscall-note
(obviously copied from the kernel, although I don't understand why).

./lib/xfrm and ./include/netlink/ are BSD-3-Clause.

So I guess until we can argue that those files don't make it into a
compiled binary, the license statement should be 
LGPL-2.1-only AND GPL-2.0-only AND GPL-2.0 WITH Linux-syscall-note and
GPL-2.0+ WITH Linux-syscall-note and BSD-3-Clause.

[1]: https://metacpan.org/pod/App::Licensecheck

 - Roland

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH 2/2] libnl3: fix license identifier (GPL-2.0-only -> LGPL-2.1-only)

[Roland Hieber]

On Wed, Oct 09, 2019 at 10:22:02AM +0200, Roland Hieber wrote:
> On Tue, Oct 08, 2019 at 10:01:50PM +0200, Andreas Pretzsch wrote:
> > One of the changes 3.4.0 -> 3.5.0 was to add SPDX tags all
> > across the source files. They are now tagged as LGPL-2.1-only.
> > 
> > The lib code itself had written LGPL-2.1-only headers already,
> > as did most of the commandline tools (src/nf-* and src/nl-*).
> > Very few of the cli tools have written GPL-2.0-only headers
> > even now, but the LGPL-2.1-only SPDX tag was added there also.
> > But given the use of those cli tools, and the meaning of LGPL
> > for regular executables, they are probably fine as LGPL, too.
> > 
> > For details, see https://github.com/thom311/libnl/pull/219
> > It was accepted mainline as commit cee0b1b 'Add SPDX identifiers'.
> > 
> > Therefore update the license tag in the rule to follow mainline.
> > 
> > Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> > ---
> >  rules/libnl3.make | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/rules/libnl3.make b/rules/libnl3.make
> > index 153c7b80e..5b3af0065 100644
> > --- a/rules/libnl3.make
> > +++ b/rules/libnl3.make
> > @@ -22,7 +22,7 @@ LIBNL3_SUFFIX	:= tar.gz
> >  LIBNL3_URL	:= https://github.com/thom311/libnl/releases/download/$(LIBNL3_RELEASE)/$(LIBNL3).$(LIBNL3_SUFFIX)
> >  LIBNL3_SOURCE	:= $(SRCDIR)/$(LIBNL3).$(LIBNL3_SUFFIX)
> >  LIBNL3_DIR	:= $(BUILDDIR)/$(LIBNL3)
> > -LIBNL3_LICENSE	:= GPL-2.0-only
> > +LIBNL3_LICENSE	:= LGPL-2.1-only
> 
> It's also a good idea to add 
> LIBNL3_LICENSE_FILES    := file://COPYING;md5=4fbd65380cdd255951079008b364516c
> so we get a hint where the license is and when it changes again.
> 
> I threw licensecheck [1] at the code. There a few files which have
> comments identifying them as GPL-2.0-only, but also now have a
> "SPDX-License-Identifier: LGPL-2.1-only" tag:
> 
> ./src/idiag-socket-details.c	GPL (v2)
> ./src/nl-addr-add.c	GPL (v2)
> ./src/nl-addr-delete.c	GPL (v2)
> ./src/nl-addr-list.c	GPL (v2)
> ./src/nl-cls-add.c	GPL (v2)
> 
> as well as several files in ./include/linux-private/linux/, which are
> GPL-2.0 WITH Linux-syscall-note or GPL-2.0+ WITH Linux-syscall-note
> (obviously copied from the kernel, although I don't understand why).
> 
> ./lib/xfrm and ./include/netlink/ are BSD-3-Clause.

Sorry, I meant ./lib/xfrm/* and ./include/netlink/xfrm/*

> 
> So I guess until we can argue that those files don't make it into a
> compiled binary, the license statement should be 
> LGPL-2.1-only AND GPL-2.0-only AND GPL-2.0 WITH Linux-syscall-note and
> GPL-2.0+ WITH Linux-syscall-note and BSD-3-Clause.
> 
> [1]: https://metacpan.org/pod/App::Licensecheck
> 
>  - Roland
> 
> -- 
> Roland Hieber                     | r.hieber@pengutronix.de     |
> Pengutronix e.K.                  | https://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
> Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH 2/2] libnl3: fix license identifier (GPL-2.0-only -> LGPL-2.1-only)

[Alexander Dahl]

Hei hei,

Am Mittwoch, 9. Oktober 2019, 10:22:02 CEST schrieb Roland Hieber:
> On Tue, Oct 08, 2019 at 10:01:50PM +0200, Andreas Pretzsch wrote:
> > One of the changes 3.4.0 -> 3.5.0 was to add SPDX tags all
> > across the source files. They are now tagged as LGPL-2.1-only.
> > 
> > The lib code itself had written LGPL-2.1-only headers already,
> > as did most of the commandline tools (src/nf-* and src/nl-*).
> > Very few of the cli tools have written GPL-2.0-only headers
> > even now, but the LGPL-2.1-only SPDX tag was added there also.
> > But given the use of those cli tools, and the meaning of LGPL
> > for regular executables, they are probably fine as LGPL, too.

I would consider that as a bug, which should be filed there.

> > For details, see https://github.com/thom311/libnl/pull/219
> > It was accepted mainline as commit cee0b1b 'Add SPDX identifiers'.

This should not have been accepted that way upstream. :-/

> > Therefore update the license tag in the rule to follow mainline.
> > 
> > Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> > ---
> > 
> >  rules/libnl3.make | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/rules/libnl3.make b/rules/libnl3.make
> > index 153c7b80e..5b3af0065 100644
> > --- a/rules/libnl3.make
> > +++ b/rules/libnl3.make
> > @@ -22,7 +22,7 @@ LIBNL3_SUFFIX	:= tar.gz
> > 
> >  LIBNL3_URL	:=
> >  https://github.com/thom311/libnl/releases/download/$(LIBNL3_RELEASE)/$(L
> >  IBNL3).$(LIBNL3_SUFFIX) LIBNL3_SOURCE	:=
> >  $(SRCDIR)/$(LIBNL3).$(LIBNL3_SUFFIX)
> >  LIBNL3_DIR	:= $(BUILDDIR)/$(LIBNL3)
> > 
> > -LIBNL3_LICENSE	:= GPL-2.0-only
> > +LIBNL3_LICENSE	:= LGPL-2.1-only
> 
> It's also a good idea to add
> LIBNL3_LICENSE_FILES    :=
> file://COPYING;md5=4fbd65380cdd255951079008b364516c so we get a hint where
> the license is and when it changes again.
> 
> I threw licensecheck [1] at the code. There a few files which have
> comments identifying them as GPL-2.0-only, but also now have a
> "SPDX-License-Identifier: LGPL-2.1-only" tag:
> 
> ./src/idiag-socket-details.c	GPL (v2)
> ./src/nl-addr-add.c	GPL (v2)
> ./src/nl-addr-delete.c	GPL (v2)
> ./src/nl-addr-list.c	GPL (v2)
> ./src/nl-cls-add.c	GPL (v2)
> 
> as well as several files in ./include/linux-private/linux/, which are
> GPL-2.0 WITH Linux-syscall-note or GPL-2.0+ WITH Linux-syscall-note
> (obviously copied from the kernel, although I don't understand why).
> 
> ./lib/xfrm and ./include/netlink/ are BSD-3-Clause.
> 
> So I guess until we can argue that those files don't make it into a
> compiled binary, the license statement should be
> LGPL-2.1-only AND GPL-2.0-only AND GPL-2.0 WITH Linux-syscall-note and
> GPL-2.0+ WITH Linux-syscall-note and BSD-3-Clause.
> 
> [1]: https://metacpan.org/pod/App::Licensecheck

FWIW, I created a ticket [1] back in May 2019 after the discussion starting 
here: 

https://www.mail-archive.com/ptxdist@pengutronix.de/msg14394.html

Maybe someone wants to add the correct SPDX identifiers and license texts and 
sent PR to upstream? As far as I could see in upstream PR #219 already, the 
maintainer would happily apply those?

Greets
Alex

[1] https://github.com/thom311/libnl/issues/215


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH 2/2] libnl3: fix license identifier (GPL-2.0-only -> LGPL-2.1-only)

[Andreas Pretzsch]

On Wed, 2019-10-09 at 10:36 +0200, Alexander Dahl wrote:
> Am Mittwoch, 9. Oktober 2019, 10:22:02 CEST schrieb Roland Hieber:
> > On Tue, Oct 08, 2019 at 10:01:50PM +0200, Andreas Pretzsch wrote:
> > > One of the changes 3.4.0 -> 3.5.0 was to add SPDX tags all
> > > across the source files. They are now tagged as LGPL-2.1-only.
> > > 
> > > The lib code itself had written LGPL-2.1-only headers already,
> > > as did most of the commandline tools (src/nf-* and src/nl-*).
> > > Very few of the cli tools have written GPL-2.0-only headers
> > > even now, but the LGPL-2.1-only SPDX tag was added there also.
> > > But given the use of those cli tools, and the meaning of LGPL
> > > for regular executables, they are probably fine as LGPL, too.
> 
> I would consider that as a bug, which should be filed there.

True.

> > > For details, see https://github.com/thom311/libnl/pull/219
> > > It was accepted mainline as commit cee0b1b 'Add SPDX
> > > identifiers'.
> 
> This should not have been accepted that way upstream. :-/

Well, yes. Guess they decided to have a life beside license tags ;-)


> [ file and license debate ]
> 
> FWIW, I created a ticket [1] back in May 2019 after the discussion
> starting here: 
> 
> https://www.mail-archive.com/ptxdist@pengutronix.de/msg14394.html
> [1] https://github.com/thom311/libnl/issues/215

Missed this. Thanks for the pointer, and esp. all the work !
Unfortunately, it somehow got lost / came to no conclusion :-(


> Maybe someone wants to add the correct SPDX identifiers and license
> texts and 
> sent PR to upstream? As far as I could see in upstream PR #219
> already, the 
> maintainer would happily apply those?

Well, guess he will.

But for the example code, he has to get the active permission of
  Thomas Graf <tgraf@suug.ch>
  Joe Damato <ice799@gmail.com>
as the relevant authors of the code for relicensing.
git log shows no other relevant contributors.

The BSD-3 code, honestly, I have no idea if there is an official route
of just relicensing all this under LGPL-2.1-only, solely for this
specific code distribution.
There might be, in the way of dual-licensing (in this case, add
another, more restrictive license), as long as the original one is
still preserved (and hence the end user has the freedom of choice to
also use the more permissive BSD-3). And choosing LGPL for ones own
usage (and distribution).
But this would be up to lawyers to answer, not me.

And trying to convince a coorporation to relicense, good luck.

Question is, who's volunteering ?
I won't, sorry. Prefer life time over this...
If anything, I'd keep the mess, add the half of dozen license tags, and
call it a night.

Best regards,
  Andreas

-- 

carpe noctem engineering
Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
Dipl.-Ing. (FH) Andreas Pretzsch        Tel. +49-(0)7307-936088-1
Lange Strasse 28a                       Fax: +49-(0)7307-936088-9
89250 Senden, Germany                   email: apr@cn-eng.de


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH] libnl3: fix license information

[Michael Olbrich]

Let's stick with the GPL-2.0-only for the tools that still have this in the
header but make it clear that this does not apply to the library by making
it conditional.
Also add the missing BSD-3-Clause identifiery and file.

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
---

So if had forgotten about the old discussion when I applied the patch. How
about this patch. I don't really care about the kernel headers. It makes no
difference if they are shipped with the package or the toolchain. The
result is the same.
And with the condition below, we still mention the GPL-2.0-only but make it
more obvious that this does not apply to libnl itself.

Michael

 rules/libnl3.make | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/rules/libnl3.make b/rules/libnl3.make
index 5b3af00659c6..191e00126831 100644
--- a/rules/libnl3.make
+++ b/rules/libnl3.make
@@ -22,7 +22,14 @@ LIBNL3_SUFFIX	:= tar.gz
 LIBNL3_URL	:= https://github.com/thom311/libnl/releases/download/$(LIBNL3_RELEASE)/$(LIBNL3).$(LIBNL3_SUFFIX)
 LIBNL3_SOURCE	:= $(SRCDIR)/$(LIBNL3).$(LIBNL3_SUFFIX)
 LIBNL3_DIR	:= $(BUILDDIR)/$(LIBNL3)
-LIBNL3_LICENSE	:= LGPL-2.1-only
+LIBNL3_LICENSE	:= LGPL-2.1-only AND BSD-3-Clause
+LIBNL3_LICENSE_FILES := \
+	file://COPYING;md5=4fbd65380cdd255951079008b364516c \
+	file://lib/xfrm/ae.c;startline=3;endline=32;md5=6813917a92b539b07534e1a79f5a6aca
+
+ifdef PTXCONF_LIBNL3_ENABLE_CLI
+LIBNL3_LICENSE	+= AND GPL-2.0-only
+endif
 
 #
 # autoconf
-- 
2.20.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] libnl3: fix license information

[Roland Hieber]

On Thu, Oct 10, 2019 at 11:25:46AM +0200, Michael Olbrich wrote:
> Let's stick with the GPL-2.0-only for the tools that still have this in the
> header but make it clear that this does not apply to the library by making
> it conditional.
> Also add the missing BSD-3-Clause identifiery and file.
> 
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---

Acked-by: Roland Hieber <rhi@pengutronix.de>

> 
> So if had forgotten about the old discussion when I applied the patch. How
> about this patch. I don't really care about the kernel headers. It makes no
> difference if they are shipped with the package or the toolchain. The
> result is the same.
> And with the condition below, we still mention the GPL-2.0-only but make it
> more obvious that this does not apply to libnl itself.
> 
> Michael
> 
>  rules/libnl3.make | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/libnl3.make b/rules/libnl3.make
> index 5b3af00659c6..191e00126831 100644
> --- a/rules/libnl3.make
> +++ b/rules/libnl3.make
> @@ -22,7 +22,14 @@ LIBNL3_SUFFIX	:= tar.gz
>  LIBNL3_URL	:= https://github.com/thom311/libnl/releases/download/$(LIBNL3_RELEASE)/$(LIBNL3).$(LIBNL3_SUFFIX)
>  LIBNL3_SOURCE	:= $(SRCDIR)/$(LIBNL3).$(LIBNL3_SUFFIX)
>  LIBNL3_DIR	:= $(BUILDDIR)/$(LIBNL3)
> -LIBNL3_LICENSE	:= LGPL-2.1-only
> +LIBNL3_LICENSE	:= LGPL-2.1-only AND BSD-3-Clause
> +LIBNL3_LICENSE_FILES := \
> +	file://COPYING;md5=4fbd65380cdd255951079008b364516c \
> +	file://lib/xfrm/ae.c;startline=3;endline=32;md5=6813917a92b539b07534e1a79f5a6aca
> +
> +ifdef PTXCONF_LIBNL3_ENABLE_CLI
> +LIBNL3_LICENSE	+= AND GPL-2.0-only
> +endif
>  
>  #
>  # autoconf
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] libnl3: fix license information

[Alexander Dahl]

Hei hei,

Am Donnerstag, 10. Oktober 2019, 11:25:46 CEST schrieb Michael Olbrich:
> Let's stick with the GPL-2.0-only for the tools that still have this in the
> header but make it clear that this does not apply to the library by making
> it conditional.
> Also add the missing BSD-3-Clause identifiery and file.
> 
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---
> 
> So if had forgotten about the old discussion when I applied the patch. How
> about this patch. I don't really care about the kernel headers. It makes no
> difference if they are shipped with the package or the toolchain. The
> result is the same.
> And with the condition below, we still mention the GPL-2.0-only but make it
> more obvious that this does not apply to libnl itself.

Acked-by: Alexander Dahl <ada@thorsis.com>

> 
> Michael
> 
>  rules/libnl3.make | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/libnl3.make b/rules/libnl3.make
> index 5b3af00659c6..191e00126831 100644
> --- a/rules/libnl3.make
> +++ b/rules/libnl3.make
> @@ -22,7 +22,14 @@ LIBNL3_SUFFIX	:= tar.gz
>  LIBNL3_URL	:=
> https://github.com/thom311/libnl/releases/download/$(LIBNL3_RELEASE)/$(LIBN
> L3).$(LIBNL3_SUFFIX) LIBNL3_SOURCE	:= $(SRCDIR)/$(LIBNL3).$(LIBNL3_SUFFIX)
>  LIBNL3_DIR	:= $(BUILDDIR)/$(LIBNL3)
> -LIBNL3_LICENSE	:= LGPL-2.1-only
> +LIBNL3_LICENSE	:= LGPL-2.1-only AND BSD-3-Clause
> +LIBNL3_LICENSE_FILES := \
> +	file://COPYING;md5=4fbd65380cdd255951079008b364516c \
> +	file://lib/xfrm/ae.c;startline=3;endline=32;md5=6813917a92b539b07534e1a79f
> 5a6aca +
> +ifdef PTXCONF_LIBNL3_ENABLE_CLI
> +LIBNL3_LICENSE	+= AND GPL-2.0-only
> +endif
> 
>  #
>  # autoconf

Greets
Alex


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] libnl3: fix license information

[Andreas Pretzsch]

On Thu, 2019-10-10 at 11:25 +0200, Michael Olbrich wrote:
> Let's stick with the GPL-2.0-only for the tools that still have this
> in the
> header but make it clear that this does not apply to the library by
> making
> it conditional.
> Also add the missing BSD-3-Clause identifiery and file.
> 
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---

Acked-by: Andreas Pretzsch <apr@cn-eng.de>


> So if had forgotten about the old discussion when I applied the
> patch. How
> about this patch. I don't really care about the kernel headers. It
> makes no
> difference if they are shipped with the package or the toolchain. The
> result is the same.
> And with the condition below, we still mention the GPL-2.0-only but
> make it
> more obvious that this does not apply to libnl itself.

Looks good, and esp. the conditional.
Thanks for the fix !

Best regards,
  Andreas

-- 

carpe noctem engineering
Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
Dipl.-Ing. (FH) Andreas Pretzsch        Tel. +49-(0)7307-936088-1
Lange Strasse 28a                       Fax: +49-(0)7307-936088-9
89250 Senden, Germany                   email: apr@cn-eng.de


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] libnl3: fix license information

[Michael Olbrich]

On Thu, Oct 10, 2019 at 01:56:24PM +0200, Andreas Pretzsch wrote:
> On Thu, 2019-10-10 at 11:25 +0200, Michael Olbrich wrote:
> > Let's stick with the GPL-2.0-only for the tools that still have this
> > in the
> > header but make it clear that this does not apply to the library by
> > making
> > it conditional.
> > Also add the missing BSD-3-Clause identifiery and file.
> > 
> > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > ---
> 
> Acked-by: Andreas Pretzsch <apr@cn-eng.de>

Right, so I messed up and accidentally didn't apply this Acked-by, just the
others. Sorry about that and thanks anyways.

Michael

> > So if had forgotten about the old discussion when I applied the
> > patch. How
> > about this patch. I don't really care about the kernel headers. It
> > makes no
> > difference if they are shipped with the package or the toolchain. The
> > result is the same.
> > And with the condition below, we still mention the GPL-2.0-only but
> > make it
> > more obvious that this does not apply to libnl itself.
> 
> Looks good, and esp. the conditional.
> Thanks for the fix !
> 
> Best regards,
>   Andreas
> 
> -- 
> 
> carpe noctem engineering
> Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
> Dipl.-Ing. (FH) Andreas Pretzsch        Tel. +49-(0)7307-936088-1
> Lange Strasse 28a                       Fax: +49-(0)7307-936088-9
> 89250 Senden, Germany                   email: apr@cn-eng.de
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] libnl3: fix license information

[Andreas Pretzsch]

On Tue, 2019-10-15 at 09:51 +0200, Michael Olbrich wrote:
> On Thu, Oct 10, 2019 at 01:56:24PM +0200, Andreas Pretzsch wrote:
> > On Thu, 2019-10-10 at 11:25 +0200, Michael Olbrich wrote:
> > > Let's stick with the GPL-2.0-only for the tools that still have
> > > this
> > > in the
> > > header but make it clear that this does not apply to the library
> > > by
> > > making
> > > it conditional.
> > > Also add the missing BSD-3-Clause identifiery and file.
> > > 
> > > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > > ---
> > 
> > Acked-by: Andreas Pretzsch <apr@cn-eng.de>
> 
> Right, so I messed up and accidentally didn't apply this Acked-by,
> just the others. Sorry about that and thanks anyways.

No worries. It's the content that matters, not the person.
And thanks for caring about the license fix.

Best regards,
  Andreas

-- 

carpe noctem engineering
Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
Dipl.-Ing. (FH) Andreas Pretzsch        Tel. +49-(0)7307-936088-1
Lange Strasse 28a                       Fax: +49-(0)7307-936088-9
89250 Senden, Germany                   email: apr@cn-eng.de


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH 2/2] libnl3: fix license identifier (GPL-2.0-only -> LGPL-2.1-only)

[Andreas Pretzsch]

On Wed, 2019-10-09 at 10:22 +0200, Roland Hieber wrote:
> On Tue, Oct 08, 2019 at 10:01:50PM +0200, Andreas Pretzsch wrote:
> > One of the changes 3.4.0 -> 3.5.0 was to add SPDX tags all
> > across the source files. They are now tagged as LGPL-2.1-only.
> > 
> > The lib code itself had written LGPL-2.1-only headers already,
> > as did most of the commandline tools (src/nf-* and src/nl-*).
> > Very few of the cli tools have written GPL-2.0-only headers
> > even now, but the LGPL-2.1-only SPDX tag was added there also.
> > But given the use of those cli tools, and the meaning of LGPL
> > for regular executables, they are probably fine as LGPL, too.
> > 
> > For details, see https://github.com/thom311/libnl/pull/219
> > It was accepted mainline as commit cee0b1b 'Add SPDX identifiers'.
> > 
> > Therefore update the license tag in the rule to follow mainline.
> > 
> > Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> > ---
> >  rules/libnl3.make | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/rules/libnl3.make b/rules/libnl3.make
> > index 153c7b80e..5b3af0065 100644
> > --- a/rules/libnl3.make
> > +++ b/rules/libnl3.make
> > @@ -22,7 +22,7 @@ LIBNL3_SUFFIX	:= tar.gz
> >  LIBNL3_URL	:= 
> > https://github.com/thom311/libnl/releases/download/$(LIBNL3_RELEASE)/$(LIBNL3).$(LIBNL3_SUFFIX
> > )
> >  LIBNL3_SOURCE	:= $(SRCDIR)/$(LIBNL3).$(LIBNL3_SUFFIX)
> >  LIBNL3_DIR	:= $(BUILDDIR)/$(LIBNL3)
> > -LIBNL3_LICENSE	:= GPL-2.0-only
> > +LIBNL3_LICENSE	:= LGPL-2.1-only
> 
> It's also a good idea to add 
> LIBNL3_LICENSE_FILES    :=
> file://COPYING;md5=4fbd65380cdd255951079008b364516c
> so we get a hint where the license is and when it changes again.

Well, this won't help here. As we have seen with this mixup.
Which is why I am not a fan of this approach for the normal case,
redundant at best, misleading at worst, like here...


> I threw licensecheck [1] at the code. There a few files which have
> comments identifying them as GPL-2.0-only, but also now have a
> "SPDX-License-Identifier: LGPL-2.1-only" tag:
> 
> ./src/idiag-socket-details.c	GPL (v2)
> ./src/nl-addr-add.c	GPL (v2)
> ./src/nl-addr-delete.c	GPL (v2)
> ./src/nl-addr-list.c	GPL (v2)
> ./src/nl-cls-add.c	GPL (v2)

Essentially, these are short examples feeding command line arguments
into library functions or dumps their result verbatim, using lib calls.
So the threshold of originality is questionable anyway.
But in a strict view, they are GPLv2-only, not LGPL, correct.
And yes, they are installed and usable on the system.

Still, from a ptxdist point of view, the result is quite the
same. Components distributed are under a copyleft license, with the
known consequences. Which are the same in this case. For ptxdist users.
If somebody takes above example/cli code and modifies it / includes it
in own code, different story. The first thing to note (and care about)
for this person would be the header in the source. Not ptxdist's issue.

Which is why I went the way of repeating upstreams pragmatic (and
somewhat sloppy, given) solution.

Of course, an upstream fix would be best.


> as well as several files in ./include/linux-private/linux/, which are
> GPL-2.0 WITH Linux-syscall-note or GPL-2.0+ WITH Linux-syscall-note
> (obviously copied from the kernel, although I don't understand why).

Which essentially says "This is an API. You need it to use Linux. Take
it and use it, it has no license effect on your code.".
Whatever Oracle dreamed of, back in the days...

So I tend to not mention these extra, for a ptxdist package license
tag.

But again, I'm not authoritative here. Neither by legal expertise (I am
not a lawyer, esp. not an IP one), not by decision.


> ./lib/xfrm and ./include/netlink/ are BSD-3-Clause.
> Sorry, I meant ./lib/xfrm/* and ./include/netlink/xfrm/*

Ok, these are really annoying. And we probably need to care.
While BSD-3 can be included in GPL just fine, the copyright notice has
to be included in the distributed license book. Including the copyright
holder (here: Texas Instruments), to my knowledge. At least we did so
before.

And this is probably nothing upstream can easily fix (like the GPL/LGPL
mixup), I guess.

Didn't see those, thanks for bringing it up !


> So I guess until we can argue that those files don't make it into a
> compiled binary,

They will. They are installed as libnl-xfrm-3 as far as I can see.

>  the license statement should be 
> LGPL-2.1-only AND GPL-2.0-only AND GPL-2.0 WITH Linux-syscall-note
> and GPL-2.0+ WITH Linux-syscall-note and BSD-3-Clause.

Plus a LIBNL3_LICENSE_FILES tag for at least one of the BSD-3 files.
If we want to go this route. What a PITA...
Someone please remind me why I decided for engineering as profession?


Now, how to proceed...

a) blow up the license tag as above (5 lics + bsd-file-header)
b) keep LGPL-2.1-only (following upstream), add bsd-file-header
   [ and try to get GPL/LGPL fixed upstream, for next release ]

Honestly, I don't know.
I tend to b), but IANAL and ptx has to decide finally.

Roland, Michael, Alexander, what do you think ?

Roland, you can update this before 2019.10 release ?
You're closest to source...

Best regards,
  Andreas

-- 

carpe noctem engineering
Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
Dipl.-Ing. (FH) Andreas Pretzsch        Tel. +49-(0)7307-936088-1
Lange Strasse 28a                       Fax: +49-(0)7307-936088-9
89250 Senden, Germany                   email: apr@cn-eng.de


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH 2/2] libnl3: fix license identifier (GPL-2.0-only -> LGPL-2.1-only)

[Roland Hieber]

On Wed, Oct 09, 2019 at 11:46:15PM +0200, Andreas Pretzsch wrote:
> On Wed, 2019-10-09 at 10:22 +0200, Roland Hieber wrote:
> > On Tue, Oct 08, 2019 at 10:01:50PM +0200, Andreas Pretzsch wrote:
> > > One of the changes 3.4.0 -> 3.5.0 was to add SPDX tags all
> > > across the source files. They are now tagged as LGPL-2.1-only.
> > > 
> > > The lib code itself had written LGPL-2.1-only headers already,
> > > as did most of the commandline tools (src/nf-* and src/nl-*).
> > > Very few of the cli tools have written GPL-2.0-only headers
> > > even now, but the LGPL-2.1-only SPDX tag was added there also.
> > > But given the use of those cli tools, and the meaning of LGPL
> > > for regular executables, they are probably fine as LGPL, too.
> > > 
> > > For details, see https://github.com/thom311/libnl/pull/219
> > > It was accepted mainline as commit cee0b1b 'Add SPDX identifiers'.
> > > 
> > > Therefore update the license tag in the rule to follow mainline.
> > > 
> > > Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> > > ---
> > >  rules/libnl3.make | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/rules/libnl3.make b/rules/libnl3.make
> > > index 153c7b80e..5b3af0065 100644
> > > --- a/rules/libnl3.make
> > > +++ b/rules/libnl3.make
> > > @@ -22,7 +22,7 @@ LIBNL3_SUFFIX	:= tar.gz
> > >  LIBNL3_URL	:= 
> > > https://github.com/thom311/libnl/releases/download/$(LIBNL3_RELEASE)/$(LIBNL3).$(LIBNL3_SUFFIX
> > > )
> > >  LIBNL3_SOURCE	:= $(SRCDIR)/$(LIBNL3).$(LIBNL3_SUFFIX)
> > >  LIBNL3_DIR	:= $(BUILDDIR)/$(LIBNL3)
> > > -LIBNL3_LICENSE	:= GPL-2.0-only
> > > +LIBNL3_LICENSE	:= LGPL-2.1-only
> > 
> > It's also a good idea to add 
> > LIBNL3_LICENSE_FILES    :=
> > file://COPYING;md5=4fbd65380cdd255951079008b364516c
> > so we get a hint where the license is and when it changes again.
> 
> Well, this won't help here. As we have seen with this mixup.
> Which is why I am not a fan of this approach for the normal case,
> redundant at best, misleading at worst, like here...
> 
> 
> > I threw licensecheck [1] at the code. There a few files which have
> > comments identifying them as GPL-2.0-only, but also now have a
> > "SPDX-License-Identifier: LGPL-2.1-only" tag:
> > 
> > ./src/idiag-socket-details.c	GPL (v2)
> > ./src/nl-addr-add.c	GPL (v2)
> > ./src/nl-addr-delete.c	GPL (v2)
> > ./src/nl-addr-list.c	GPL (v2)
> > ./src/nl-cls-add.c	GPL (v2)
> 
> Essentially, these are short examples feeding command line arguments
> into library functions or dumps their result verbatim, using lib calls.
> So the threshold of originality is questionable anyway.
> But in a strict view, they are GPLv2-only, not LGPL, correct.
> And yes, they are installed and usable on the system.
> 
> Still, from a ptxdist point of view, the result is quite the
> same. Components distributed are under a copyleft license, with the
> known consequences. Which are the same in this case. For ptxdist users.
> If somebody takes above example/cli code and modifies it / includes it
> in own code, different story. The first thing to note (and care about)
> for this person would be the header in the source. Not ptxdist's issue.
> 
> Which is why I went the way of repeating upstreams pragmatic (and
> somewhat sloppy, given) solution.
> 
> Of course, an upstream fix would be best.
> 
> 
> > as well as several files in ./include/linux-private/linux/, which are
> > GPL-2.0 WITH Linux-syscall-note or GPL-2.0+ WITH Linux-syscall-note
> > (obviously copied from the kernel, although I don't understand why).
> 
> Which essentially says "This is an API. You need it to use Linux. Take
> it and use it, it has no license effect on your code.".
> Whatever Oracle dreamed of, back in the days...
> 
> So I tend to not mention these extra, for a ptxdist package license
> tag.
> 
> But again, I'm not authoritative here. Neither by legal expertise (I am
> not a lawyer, esp. not an IP one), not by decision.
> 
> 
> > ./lib/xfrm and ./include/netlink/ are BSD-3-Clause.
> > Sorry, I meant ./lib/xfrm/* and ./include/netlink/xfrm/*
> 
> Ok, these are really annoying. And we probably need to care.
> While BSD-3 can be included in GPL just fine, the copyright notice has
> to be included in the distributed license book. Including the copyright
> holder (here: Texas Instruments), to my knowledge. At least we did so
> before.
> 
> And this is probably nothing upstream can easily fix (like the GPL/LGPL
> mixup), I guess.
> 
> Didn't see those, thanks for bringing it up !
> 
> 
> > So I guess until we can argue that those files don't make it into a
> > compiled binary,
> 
> They will. They are installed as libnl-xfrm-3 as far as I can see.
> 
> >  the license statement should be 
> > LGPL-2.1-only AND GPL-2.0-only AND GPL-2.0 WITH Linux-syscall-note
> > and GPL-2.0+ WITH Linux-syscall-note and BSD-3-Clause.
> 
> Plus a LIBNL3_LICENSE_FILES tag for at least one of the BSD-3 files.
> If we want to go this route. What a PITA...
> Someone please remind me why I decided for engineering as profession?
> 
> 
> Now, how to proceed...
> 
> a) blow up the license tag as above (5 lics + bsd-file-header)
> b) keep LGPL-2.1-only (following upstream), add bsd-file-header
>    [ and try to get GPL/LGPL fixed upstream, for next release ]

I think the fixup patch from Michael just now is already the most
appropriate choice here. Upstream knows about the GPL-2.0 issue in the
tools, so there is nothing left for us to do here except wait for a fix
and a release.

This is not the first package where the LICENSE file says different
things than the source files... :)

 - Roland

> 
> Honestly, I don't know.
> I tend to b), but IANAL and ptx has to decide finally.
> 
> Roland, Michael, Alexander, what do you think ?
> 
> Roland, you can update this before 2019.10 release ?
> You're closest to source...
> 
> Best regards,
>   Andreas
> 
> -- 
> 
> carpe noctem engineering
> Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
> Dipl.-Ing. (FH) Andreas Pretzsch        Tel. +49-(0)7307-936088-1
> Lange Strasse 28a                       Fax: +49-(0)7307-936088-9
> 89250 Senden, Germany                   email: apr@cn-eng.de
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de