mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Juergen Borleis <jbe@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH] logrotate: change from single config file to drop-in directory
Date: Thu,  5 Sep 2019 12:37:50 +0200	[thread overview]
Message-ID: <20190905103750.12681-1-jbe@pengutronix.de> (raw)

Instead of using only one single config file, a drop-in directory is more
useful to support various users of 'logrotate'.

This change still expects the BSP to provide the '/etc/logrotate.d'
directory and the required config files in there.

Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
---
 projectroot/etc/logrotate.conf | 14 +-------------
 rules/logrotate.in             |  7 ++++++-
 2 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/projectroot/etc/logrotate.conf b/projectroot/etc/logrotate.conf
index d872dcc5d..e3d85c4ff 100644
--- a/projectroot/etc/logrotate.conf
+++ b/projectroot/etc/logrotate.conf
@@ -1,13 +1 @@
-/var/log/syslog {
-	missingok
-
-	# rotate after X bytes - ignore time
-	size 512k
-
-	# keep backlog of X
-	rotate 20
-
-	postrotate
-		systemctl restart rsyslog
-	endscript
-}
+include /etc/logrotate.d
diff --git a/rules/logrotate.in b/rules/logrotate.in
index 097804017..f3b465b87 100644
--- a/rules/logrotate.in
+++ b/rules/logrotate.in
@@ -15,8 +15,13 @@ menuconfig LOGROTATE
 	  log file gets to a certain size. Normally, logrotate runs as
 	  a daily cron job.
 
+	  In order to make 'logrotate' work at run-time, a directory
+	  '/etc/logrotate.d' is required which must contain your own 'logrotate'
+	  config files (refer the manpage). There are no defaults in this
+	  package.
+
 	  Note: on a read-only root filesystem this package still requires a
-	  writable '/var/lib' for its run-time information.
+	  writable '/var/lib' for its run-time state information.
 
 if LOGROTATE
 
-- 
2.11.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

             reply	other threads:[~2019-09-05 10:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 10:37 Juergen Borleis [this message]
2019-09-05 11:00 ` Alexander Dahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190905103750.12681-1-jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox