[ptxdist] [PATCH] rt-tests: backfire: Don't include asm/uaccess.h directly

[ptxdist] [PATCH] rt-tests: backfire: Don't include asm/uaccess.h directly

[Sultan Alsawaf]

From: Sultan Alsawaf <sultan@kerneltoast.com>

Architecture-specific uaccess.h headers can have dependencies on
linux/uaccess.h (i.e., VERIFY_WRITE), so it cannot be included directly.
Since linux/uaccess.h includes asm/uaccess.h, just do that instead.

This fixes compile errors with certain kernels and architectures.

Signed-off-by: Sultan Alsawaf <sultan@kerneltoast.com>
---
 src/backfire/backfire.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backfire/backfire.c b/src/backfire/backfire.c
index aaf9c4a..a8ac9f5 100644
--- a/src/backfire/backfire.c
+++ b/src/backfire/backfire.c
@@ -30,8 +30,8 @@
 #include <linux/miscdevice.h>
 #include <linux/proc_fs.h>
 #include <linux/spinlock.h>
+#include <linux/uaccess.h>
 
-#include <asm/uaccess.h>
 #include <asm/system.h>
 
 #define BACKFIRE_MINOR MISC_DYNAMIC_MINOR
-- 
2.23.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] rt-tests: backfire: Don't include asm/uaccess.h directly

[Roland Hieber]

Hi Sultan,

On Thu, Aug 29, 2019 at 09:05:51AM -0700, Sultan Alsawaf wrote:
> From: Sultan Alsawaf <sultan@kerneltoast.com>
> 
> Architecture-specific uaccess.h headers can have dependencies on
> linux/uaccess.h (i.e., VERIFY_WRITE), so it cannot be included directly.
> Since linux/uaccess.h includes asm/uaccess.h, just do that instead.
> 
> This fixes compile errors with certain kernels and architectures.
> 
> Signed-off-by: Sultan Alsawaf <sultan@kerneltoast.com>
> ---
>  src/backfire/backfire.c | 2 +-

Sorry, there is no such file in the PTXdist git repository [1]. I guess
you want to apply that patch to the rt-tests package, so it should live
somewhere in patches/rt-tests-1.0/, next to a series file. See
the section "Patching Packages" [2] in the manual for a guide.

In that case, it's also good style to submit the patch to the upstream
project, in this case rt-tests, so we can remove it in PTXdist somewhen
in the future :)

[1]: https://git.pengutronix.de/cgit/ptxdist/
[2]: https://www.ptxdist.org/doc/dev_manual.html#patching-packages

 - Roland

>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/backfire/backfire.c b/src/backfire/backfire.c
> index aaf9c4a..a8ac9f5 100644
> --- a/src/backfire/backfire.c
> +++ b/src/backfire/backfire.c
> @@ -30,8 +30,8 @@
>  #include <linux/miscdevice.h>
>  #include <linux/proc_fs.h>
>  #include <linux/spinlock.h>
> +#include <linux/uaccess.h>
>  
> -#include <asm/uaccess.h>
>  #include <asm/system.h>
>  
>  #define BACKFIRE_MINOR MISC_DYNAMIC_MINOR
> -- 
> 2.23.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de