From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: From: Roland Hieber Date: Thu, 29 Aug 2019 13:03:19 +0200 Message-Id: <20190829110319.17380-1-rhi@pengutronix.de> MIME-Version: 1.0 Subject: [ptxdist] [PATCH] platform: make clear that libc version is not only used for checking List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de Cc: Roland Hieber With the old wording it reads like the version can be left empty. However, if the libc should be installed to the target (e.g. by selecting anything in the GLIBC or UCLIBC section), this version must be set, or the respective targetinstall stage will error: --------------------------- target: glibc.targetinstall --------------------------- ptxdist: error: ptxd_make_xpkg_init: please define _VERSION Signed-off-by: Roland Hieber --- platforms/toolchain.in | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/platforms/toolchain.in b/platforms/toolchain.in index 2cf2009ec411..c219fe29de25 100644 --- a/platforms/toolchain.in +++ b/platforms/toolchain.in @@ -46,23 +46,25 @@ endchoice if LIBC_GLIBC config GLIBC_VERSION string - prompt "check for specific glibc version" + prompt "glibc version" default "2.23" help Specify the glibc version this BSP shall be built with. This information - is used to guess the toolchain path if you use "ptxdist toolchain" - without an argument. + is used to guess the toolchain path if you use "ptxdist toolchain" + without an argument, and to install the glibc into the target file + system. endif if LIBC_UCLIBC config UCLIBC_VERSION string - prompt "check for specific uClibc version" + prompt "uClibc version" default "0.9.33.2" help Specify the uClibc version this BSP shall be built with. This information - is used to guess the toolchain path if you use "ptxdist toolchain" - without an argument. + is used to guess the toolchain path if you use "ptxdist toolchain" + without an argument. and to install the uClibc into the target file + system. endif config GNU_TARGET -- 2.23.0 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de