mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [ptxdist] [PATCH] platform: make clear that libc version is not only used for checking
Date: Thu, 29 Aug 2019 13:03:19 +0200	[thread overview]
Message-ID: <20190829110319.17380-1-rhi@pengutronix.de> (raw)

With the old wording it reads like the version can be left empty.
However, if the libc should be installed to the target (e.g. by
selecting anything in the GLIBC or UCLIBC section), this version must be
set, or the respective targetinstall stage will error:

    ---------------------------
    target: glibc.targetinstall
    ---------------------------

    ptxdist: error: ptxd_make_xpkg_init: please define <PKG>_VERSION

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 platforms/toolchain.in | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/platforms/toolchain.in b/platforms/toolchain.in
index 2cf2009ec411..c219fe29de25 100644
--- a/platforms/toolchain.in
+++ b/platforms/toolchain.in
@@ -46,23 +46,25 @@ endchoice
 if LIBC_GLIBC
 config GLIBC_VERSION
 	string
-	prompt "check for specific glibc version"
+	prompt "glibc version"
 	default "2.23"
 	help
 	  Specify the glibc version this BSP shall be built with. This information
-          is used to guess the toolchain path if you use "ptxdist toolchain"
-	  without an argument.
+	  is used to guess the toolchain path if you use "ptxdist toolchain"
+	  without an argument, and to install the glibc into the target file
+	  system.
 endif
 
 if LIBC_UCLIBC
 config UCLIBC_VERSION
 	string
-	prompt "check for specific uClibc version"
+	prompt "uClibc version"
 	default "0.9.33.2"
 	help
 	  Specify the uClibc version this BSP shall be built with. This information
-          is used to guess the toolchain path if you use "ptxdist toolchain"
-	  without an argument.
+	  is used to guess the toolchain path if you use "ptxdist toolchain"
+	  without an argument. and to install the uClibc into the target file
+	  system.
 endif
 
 config GNU_TARGET
-- 
2.23.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

                 reply	other threads:[~2019-08-29 11:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190829110319.17380-1-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox