mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Alexander Dahl <ada@thorsis.com>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] mosquitto: version bump 1.4.14 -> 1.6.4
Date: Fri, 9 Aug 2019 12:06:11 +0200	[thread overview]
Message-ID: <20190809100611.b5y2i4i6lo3slvph@pengutronix.de> (raw)
In-Reply-To: <2206289.70BF7xdW8B@ada>

On Fri, Aug 09, 2019 at 12:01:33PM +0200, Alexander Dahl wrote:
> Am Freitag, 9. August 2019, 11:52:03 CEST schrieb Michael Olbrich:
> > On Fri, Aug 09, 2019 at 10:47:44AM +0200, Alexander Dahl wrote:
> > > This includes a lot of security fixes, bug fixes, fixed build issues,
> > > new features, and removed features. Notable for this package:
> > > 
> > > * libuuid support removed
> > > * new systemd service unit
> > > * copied config file from upstream example, changed unpriviledged user
> > > 
> > >   to "daemon" (already exists in ptxdist)
> > 
> > The default user is mosquitto, right? Please introduce that user and copy
> > the example mosquitto.conf to the pkgdir in the install stage. This way it
> > will be used as fallback if no other config is found.
> > Otherwise the config in projectroot/ will become outdated if we're not very
> > careful.
> 
> That came to my mind, but I was not sure if that's desired. Now I know. ;-)
> 
> > > Notes:
> > >     I squeezed the version bump and the new stuff for running the broker
> > >     with systemd in one commit. Let me know if I should split it up.
> 
> I will split up the patch into several patches and resend a v2 then.

Ah, I missed that. Several patches are good.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2019-08-09 10:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  8:47 Alexander Dahl
2019-08-09  9:52 ` Michael Olbrich
2019-08-09 10:01   ` Alexander Dahl
2019-08-09 10:06     ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190809100611.b5y2i4i6lo3slvph@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ada@thorsis.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox