mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist]  [PATCH 2/4] optee: version bump 3.5.0 → 3.6.0
Date: Wed, 7 Aug 2019 17:07:32 +0200	[thread overview]
Message-ID: <20190807150732.udhg5sj2wuctndnn@pengutronix.de> (raw)
In-Reply-To: <764f7463ddc17ee89d53c0d128b15606883ee8b6.camel@pengutronix.de>

On Wed, Aug 07, 2019 at 02:38:21PM +0200, Rouven Czerwinski wrote:
> On Wed, 2019-08-07 at 12:57 +0200, Michael Olbrich wrote:
> > On Thu, Jul 25, 2019 at 11:05:18AM +0200, Rouven Czerwinski wrote:
> > > On Thu, 2019-07-25 at 10:53 +0200, Lucas Stach wrote:
> > > > Am Donnerstag, den 25.07.2019, 10:25 +0200 schrieb Rouven
> > > > Czerwinski:
> > > > > The OP-TEE build requires pyelftools in the python3 flavour
> > > > > now.
> > > > > 
> > > > > Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> > > > > ---
> > > > >  platforms/optee.in | 1 +
> > > > >  rules/optee.make   | 4 ++--
> > > > >  2 files changed, 3 insertions(+), 2 deletions(-)
> > > > > 
> > > > > diff --git a/platforms/optee.in b/platforms/optee.in
> > > > > index dc31f66..cfdd44b 100644
> > > > > --- a/platforms/optee.in
> > > > > +++ b/platforms/optee.in
> > > > > @@ -5,6 +5,7 @@ menuconfig OPTEE
> > > > >  	bool
> > > > >  	depends on ARCH_ARM || ARCH_ARM64
> > > > >  	depends on !ARCH_ARM64 || BROKEN
> > > > > +	select HOST_SYSTEM_PYTHON3_PYELFTOOLS
> > > > 
> > > > Missing "select HOST_SYSTEM_PYTHON3".
> > > 
> > > Thanks, fix queued for a V2.
> > 
> > Hmmm, optee currently selects HOST_SYSTEM_PYTHON as well (see
> > rules/optee.in). Do we really need both versions?
> 
> Unfortunately, yes. Currently not all scripts are converted to python3.

So we always need both versions at build-time? :-/
Please collect the dependencies in on file. I don't care if it's in rules/
or platforms/.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2019-08-07 15:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25  8:25 [ptxdist] [PATCH 0/4] OP-TEE Bump to 3.6.0 Rouven Czerwinski
2019-07-25  8:25 ` [ptxdist] [PATCH 1/4] host-system-python3: add pyelftools Rouven Czerwinski
2019-07-25  8:25 ` [ptxdist] [PATCH 2/4] optee: version bump 3.5.0 → 3.6.0 Rouven Czerwinski
2019-07-25  8:53   ` Lucas Stach
2019-07-25  9:05     ` Rouven Czerwinski
2019-08-07 10:57       ` Michael Olbrich
2019-08-07 12:38         ` Rouven Czerwinski
2019-08-07 15:07           ` Michael Olbrich [this message]
2019-07-25  8:25 ` [ptxdist] [PATCH 3/4] optee-client: " Rouven Czerwinski
2019-07-25  8:25 ` [ptxdist] [PATCH 4/4] optee-test: " Rouven Czerwinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190807150732.udhg5sj2wuctndnn@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox