From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28]
 helo=dude02.lab.pengutronix.de)
 by metis.ext.pengutronix.de with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>) id 1hvL0i-0004O9-2A
 for ptxdist@pengutronix.de; Wed, 07 Aug 2019 14:25:44 +0200
Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.89)
 (envelope-from <mol@pengutronix.de>) id 1hvL0h-000421-QW
 for ptxdist@pengutronix.de; Wed, 07 Aug 2019 14:25:43 +0200
Date: Wed, 7 Aug 2019 14:25:43 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20190807122543.ze62u4w6ovrnfwar@pengutronix.de>
References: <20190805081842.24530-1-guille.rodriguez@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20190805081842.24530-1-guille.rodriguez@gmail.com>
Subject: Re: [ptxdist] [PATCH] fbset: Add option to install /etc/fb.modes
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de

On Mon, Aug 05, 2019 at 10:18:42AM +0200, Guillermo Rodr=EDguez wrote:
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
>  rules/fbset.in   | 14 ++++++++++++--
>  rules/fbset.make |  4 +++-
>  2 files changed, 15 insertions(+), 3 deletions(-)
> =

> diff --git a/rules/fbset.in b/rules/fbset.in
> index c2122c51b..64dd9ec55 100644
> --- a/rules/fbset.in
> +++ b/rules/fbset.in
> @@ -1,11 +1,21 @@
>  ## SECTION=3Dmultimedia_framebuffer
>  =

> -config FBSET
> +menuconfig FBSET
>  	tristate
> -	prompt "fbset"
> +	prompt "fbset                         "
>  	select HOST_FLEX
>  	help
>  	  fbset is a system utility to show or change the settings
>  	  of the frame buffer device. The frame buffer device pro-
>  	  vides a simple and unique interface to access different
>  	  kinds of graphic displays.
> +
> +if FBSET
> +
> +config FBSET_FBMODES
> +	bool
> +	prompt "install /etc/fb.modes"
> +	help
> +	  Install /etc/fb.modes file.
> +
> +endif
> diff --git a/rules/fbset.make b/rules/fbset.make
> index 0d34d8959..955480b21 100644
> --- a/rules/fbset.make
> +++ b/rules/fbset.make
> @@ -45,7 +45,9 @@ $(STATEDIR)/fbset.targetinstall:
>  	@$(call install_fixup, fbset,DESCRIPTION,missing)
>  =

>  	@$(call install_copy, fbset, 0, 0, 0755, -, /usr/sbin/fbset)
> -
> +ifdef PTXCONF_FBSET_FBMODES
> +	@$(call install_alternative, fbset, 0, 0, 0644, /etc/fb.modes)
> +endif

Hmmm, I don't like options that are broken by default.
Please add a default file in projectroot/.

Michael

>  	@$(call install_finish, fbset)
>  =

>  	@$(call touch)
> -- =

> 2.21.0
> =

> =

> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> =


-- =

Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de