From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hvKNr-0008Sy-Ne for ptxdist@pengutronix.de; Wed, 07 Aug 2019 13:45:35 +0200 Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hvKNr-0005YY-Fd for ptxdist@pengutronix.de; Wed, 07 Aug 2019 13:45:35 +0200 Date: Wed, 7 Aug 2019 13:45:35 +0200 From: Michael Olbrich Message-ID: <20190807114535.xl4egdfkrtse56gy@pengutronix.de> References: <20190807092733.26364-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190807092733.26364-1-u.kleine-koenig@pengutronix.de> Subject: Re: [ptxdist] [PATCH] nfsutils: don't install nfsiostat without ensuring python is available List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Wed, Aug 07, 2019 at 11:27:33AM +0200, Uwe Kleine-K=F6nig wrote: > nfsiostat is a python script. Introduce a new suboption to select > PYTHON and don't install nfsiostat if this is disabled. > = > Signed-off-by: Uwe Kleine-K=F6nig > --- > rules/nfsutils.in | 7 +++++++ > rules/nfsutils.make | 5 ++++- > 2 files changed, 11 insertions(+), 1 deletion(-) > = > diff --git a/rules/nfsutils.in b/rules/nfsutils.in > index ef7eb7b98d60..34d237737024 100644 > --- a/rules/nfsutils.in > +++ b/rules/nfsutils.in > @@ -9,6 +9,7 @@ menuconfig NFSUTILS > select RPCBIND if RUNTIME > select LIBTIRPC if GLOBAL_IPV6 > select ROOTFS_PROTOCOLS if NFSUTILS_CLIENT > + select PYTHON if NFSUTILS_PYTHON Hmm, I don't like this. The scripts works with python3 as well if PTXCONF_PYTHON3_SYMLINK is enabled. Maybe like this: select PYTHON3 if NFSUTILS_PYTHON && !PYTHON && RUNTIME select PYTHON3_SYMLINK if NFSUTILS_PYTHON && !PYTHON && RUNTIME It's not a build-time dependency, and I think we should prefer Python3 here. Michael > select ROOTFS_VAR_LIB if RUNTIME > help > The Sun Network Filesystem (NFS) protocol provides transparent remote > @@ -32,6 +33,12 @@ config NFSUTILS_SERVER > help > Install all tools and daemons to run an NFS server. > = > +config NFSUTILS_PYTHON > + bool > + prompt "install python utilities" > + help > + Install tools depending on Python. Currently this affects nfsiostat o= nly > + > config NFSUTILS_NFSD_STARTSCRIPT > bool > depends on NFSUTILS_SERVER > diff --git a/rules/nfsutils.make b/rules/nfsutils.make > index 5986d51fd716..ff1f4cae0560 100644 > --- a/rules/nfsutils.make > +++ b/rules/nfsutils.make > @@ -77,7 +77,6 @@ $(STATEDIR)/nfsutils.targetinstall: > @$(call install_fixup, nfsutils,DESCRIPTION,"Network Filesystem Support= ") > = > @$(call install_copy, nfsutils, 0, 0, 0755, -, /usr/sbin/nfsstat) > - @$(call install_copy, nfsutils, 0, 0, 0755, -, /usr/sbin/nfsiostat) > @$(call install_copy, nfsutils, 0, 0, 0755, -, /usr/sbin/showmount) > = > @$(call install_copy, nfsutils, 0, 0, 0755, -, /usr/sbin/rpc.statd) > @@ -119,6 +118,10 @@ ifdef PTXCONF_NFSUTILS_SERVER > /etc/exports) > endif > = > +ifdef PTXCONF_NFSUTILS_PYTHON > + @$(call install_copy, nfsutils, 0, 0, 0755, -, /usr/sbin/nfsiostat) > +endif > + > # # > # # busybox init: start scripts > # # > -- = > 2.20.1 > = > = > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de