From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>) id 1hvJWa-0002zk-OQ
 for ptxdist@pengutronix.de; Wed, 07 Aug 2019 12:50:32 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.89)
 (envelope-from <mol@pengutronix.de>) id 1hvJWa-0005Ra-FZ
 for ptxdist@pengutronix.de; Wed, 07 Aug 2019 12:50:32 +0200
Date: Wed, 7 Aug 2019 12:50:32 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20190807105032.33jorssrz2s676lh@pengutronix.de>
References: <20190724090428.4344-1-lapeddk@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20190724090428.4344-1-lapeddk@gmail.com>
Subject: Re: [ptxdist] [PATCH] gettext: add envsubst option
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de

On Wed, Jul 24, 2019 at 11:04:28AM +0200, Lars Pedersen wrote:
> For environment variable templating
> 
> Signed-off-by: Lars Pedersen <lapeddk@gmail.com>
> ---
>  rules/gettext.in   | 14 +++++++++++++-
>  rules/gettext.make |  4 ++++
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/gettext.in b/rules/gettext.in
> index 5b971f7d1..1b322ae35 100644
> --- a/rules/gettext.in
> +++ b/rules/gettext.in
> @@ -1,5 +1,5 @@
>  ## SECTION=system_libraries
> -config GETTEXT
> +menuconfig GETTEXT
>  	tristate
>  	prompt "gettext (gnu)"

Add spaces at the end to align the '-->'

>  	select LIBC_M
> @@ -10,3 +10,15 @@ config GETTEXT
>  	  The gettext program translates a natural language
>  	  message into the user's language, by looking up
>  	  the translation in a message catalog.
> +
> +
> +if GETTEXT
> +
> +config GETTEXT_ENVSUBST
> +	bool
> +	default n

Remove this line. It's the default.

Michael

> +	prompt "envsubst"
> +	help
> +	  Substitutes environment variables in shell format strings
> +
> +endif
> diff --git a/rules/gettext.make b/rules/gettext.make
> index 0bda25c96..dd1d22ffb 100644
> --- a/rules/gettext.make
> +++ b/rules/gettext.make
> @@ -71,6 +71,10 @@ $(STATEDIR)/gettext.targetinstall:
>  	@$(call install_fixup, gettext,AUTHOR,"Robert Schwebel <r.schwebel@pengutronix.de>")
>  	@$(call install_fixup, gettext,DESCRIPTION,missing)
>  
> +ifdef PTXCONF_GETTEXT_ENVSUBST
> +	@$(call install_copy, gettext, 0, 0, 0755, -, /usr/bin/envsubst)
> +endif
> +
>  	@$(call install_copy, gettext, 0, 0, 0755, -, /usr/bin/xgettext)
>  	@$(call install_copy, gettext, 0, 0, 0755, -, /usr/bin/gettext)
>  
> -- 
> 2.21.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de